feat(cookie): prevent aggressive session cookie expiration#284
Merged
hardy-dev-infinilabs merged 3 commits intomainfrom Apr 30, 2026
Merged
feat(cookie): prevent aggressive session cookie expiration#284hardy-dev-infinilabs merged 3 commits intomainfrom
hardy-dev-infinilabs merged 3 commits intomainfrom
Conversation
yaojp123
approved these changes
Apr 24, 2026
hardy-dev-infinilabs
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Introduce a threshold-based cleanup mechanism for session cookies. Check the Cookie header size first and only trigger cleanup when it exceeds 6 KB, leaving headroom before the 8 KB browser/server limit. This ensures that:
The tradeoff is intentional — you only lose foreign sessions when the alternative would be broken requests from header overflow.
Rationale for this change
Standards checklist