Skip to content

feat: upgrade google.golang.org/api package#2889

Open
NguyenHoangSon96 wants to merge 18 commits intomasterfrom
feat/upgrade-google-api-package
Open

feat: upgrade google.golang.org/api package#2889
NguyenHoangSon96 wants to merge 18 commits intomasterfrom
feat/upgrade-google-api-package

Conversation

@NguyenHoangSon96
Copy link
Copy Markdown
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Mar 30, 2026

Required checklist

  • Sample config files updated (both /etc folder and NewDemoConfig methods) (influxdb and plutonium)
  • openapi swagger.yml updated (if modified API) - link openapi PR
  • Signed CLA (if not already signed)

Description

  • Change from this truct DefaultCredentialsOptions{} in "google.golang.org/grpc@v1.79.3/credentials/google/google.go" file will make code in the "google.golang.org/api" package not working anymore, so we need to upgrade the "google.golang.org/api" to the latest version v0.273.0.

Note for reviewers:

  • This PR will fix this dependabot PR

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Mar 30, 2026
@NguyenHoangSon96
Copy link
Copy Markdown
Contributor Author

Hi @bnpfeife, @jdstrand
Any reason why we should not update the "quay.io/influxdb/cross-builder" image environment variable "PROTOC_GEN_GO_VER" from "v1.34.1" to "v1.36.11"?
I'm asking because I'm upgrading "grpc" package to "1.79.3" and It will need other packages to upgrade also.
Currently, the error in "static-code-checks" can be fixed by upgrading "PROTOC_GEN_GO_VER" to "v1.36.11" and re-run go generate ./... command.

@jdstrand
Copy link
Copy Markdown
Contributor

jdstrand commented Apr 6, 2026

Hi @bnpfeife, @jdstrand Any reason why we should not update the "quay.io/influxdb/cross-builder" image environment variable "PROTOC_GEN_GO_VER" from "v1.34.1" to "v1.36.11"? I'm asking because I'm upgrading "grpc" package to "1.79.3" and It will need other packages to upgrade also. Currently, the error in "static-code-checks" can be fixed by upgrading "PROTOC_GEN_GO_VER" to "v1.36.11" and re-run go generate ./... command.

More than just kapacitor uses the cross-builder, so if updating, would have to be sure the other repos are still ok. @bnpfeife, thoughts?

Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use the version of protobuf which is in cross-builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants