[IMP] crm_sale_ux: Implement auto mark opportunities as Won feature o…#1680
Closed
lef-adhoc wants to merge 1 commit into
Closed
[IMP] crm_sale_ux: Implement auto mark opportunities as Won feature o…#1680lef-adhoc wants to merge 1 commit into
lef-adhoc wants to merge 1 commit into
Conversation
Contributor
|
|
…n sales order confirmation
lef-adhoc
force-pushed
the
19.0-t-68144-lef
branch
from
48e627c to
52b4c30
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Este PR agrega una opción de configuración en CRM para que, al confirmar una cotización/pedido de venta vinculado a una oportunidad, dicha oportunidad se marque automáticamente como Ganada (Won). Esto extiende el módulo crm_sale_ux para alinear el flujo de ventas con el estado del pipeline CRM.
Changes:
- Agrega un setting en Ajustes de CRM para habilitar/deshabilitar el auto-marcado de oportunidades como Won al confirmar ventas.
- Sobrescribe
sale.order.action_confirm()para, si el setting está activo, ejecutaraction_set_won()sobre las oportunidades vinculadas. - Incorpora tests automatizados que cubren el comportamiento habilitado/deshabilitado.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crm_sale_ux/views/res_config_settings_views.xml | Agrega el bloque de setting en la vista de configuración de CRM. |
| crm_sale_ux/models/res_config_settings.py | Define el booleano con config_parameter para persistir el setting. |
| crm_sale_ux/models/sale_order.py | Implementa el marcado automático como Won tras action_confirm() cuando está habilitado. |
| crm_sale_ux/tests/test_auto_set_won.py | Agrega pruebas para validar ambos escenarios (setting on/off). |
| crm_sale_ux/tests/init.py | Registra el archivo de tests nuevo. |
| crm_sale_ux/models/init.py | Exporta los nuevos modelos del módulo. |
| crm_sale_ux/init.py | Importa models para que carguen las extensiones. |
| crm_sale_ux/README.rst | Documenta la nueva opción de configuración. |
| crm_sale_ux/manifest.py | Ajusta dependencias y declara la nueva vista en data. |
|
|
||
| sale_exception_installed = self.env["sale.order"]._fields.get("ignore_exception") | ||
| if sale_exception_installed: | ||
| self.env["exception.rule"].search([("active", "=", True)]).write({"active": False}) |
Contributor
|
@roboadhoc r+ bump |
roboadhoc
pushed a commit
that referenced
this pull request
May 28, 2026
…n sales order confirmation closes #1680 Signed-off-by: matiasperalta1 <mnp@adhoc.com.ar>
roboadhoc
added a commit
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n sales order confirmation