feat: use NPT sims for water + solvent benchmarks#140
Draft
mcarobene-id wants to merge 5 commits into
Draft
Conversation
|
Marco Carobene seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
4613eab to
cd6e92e
Compare
cd6e92e to
1d0d319
Compare
mcarobene-id
commented
Jun 17, 2026
Comment on lines
22
to
23
| equilibrated. For every specific atom pair (e.g., **oxygen-oxygen** in water) the radial distribution | ||
| function (**RDF** or **g(r)**) is calculated from the simulation. |
Collaborator
Author
There was a problem hiding this comment.
TODO: Add details RE how the densities are computed and (below) what experimental values we compare to
lwalew
reviewed
Jun 18, 2026
lwalew
reviewed
Jun 18, 2026
Total charge is integral, and some external calculators (e.g. UMA's FAIRChemCalculator) reject a float charge. Storing 0 instead of 0.0 fixes those without affecting mlip models (which coerce internally). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Description
This PR updates the benchmarks (
WaterRadialDistributionBenchmark,SolventRadialDistributionBenchmark) to use the NPT ensemble rather than NVT, as an NPT integrator was recently added tomlipv2.Checklist for adding a new benchmark
all abstract method implementations.
testing pattern.