Skip to content

feat: Add Spyne instrumentation#706

Merged
GSVarsha merged 9 commits intomainfrom
spyne_instrumentation
Mar 20, 2025
Merged

feat: Add Spyne instrumentation#706
GSVarsha merged 9 commits intomainfrom
spyne_instrumentation

Conversation

@GSVarsha
Copy link
Copy Markdown
Contributor

@GSVarsha GSVarsha commented Mar 10, 2025 •
edited
Loading

feat: Add Spyne instrumentation

@GSVarsha GSVarsha added this to the H1-2025 milestone Mar 10, 2025
@GSVarsha GSVarsha self-assigned this Mar 10, 2025
@GSVarsha GSVarsha requested a review from a team as a code owner March 10, 2025 07:46
CagriYonca
CagriYonca reviewed Mar 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@CagriYonca CagriYonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

Comment thread src/instana/__init__.py Outdated
Comment thread src/instana/instrumentation/spyne.py Outdated
Comment thread src/instana/instrumentation/spyne.py Outdated
Comment thread src/instana/instrumentation/spyne.py Outdated
Comment thread src/instana/instrumentation/spyne.py Outdated
Comment thread src/instana/span/kind.py Outdated
Comment thread src/instana/span/kind.py Outdated
pvital
pvital reviewed Mar 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. Please address @CagriYonca requests.

Comment thread src/instana/instrumentation/spyne.py Outdated
Comment thread src/instana/span/kind.py Outdated
@GSVarsha GSVarsha force-pushed the spyne_instrumentation branch 2 times, most recently from 075397f to fff7b7a Compare March 13, 2025 10:51
@GSVarsha GSVarsha requested review from CagriYonca and pvital March 13, 2025 10:59
@GSVarsha GSVarsha force-pushed the spyne_instrumentation branch 2 times, most recently from 2aff008 to 4e10256 Compare March 17, 2025 11:08
@GSVarsha GSVarsha changed the title feat: Add Spyne instrumentation (support with standard WSGI wrapper) feat: Add Spyne instrumentation Mar 17, 2025
CagriYonca
CagriYonca approved these changes Mar 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@CagriYonca CagriYonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Good Job Varsha!

pvital
pvital requested changes Mar 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor request.

Comment thread src/instana/__init__.py Outdated
@GSVarsha GSVarsha force-pushed the spyne_instrumentation branch from 4e10256 to eecc4a4 Compare March 19, 2025 15:58
@GSVarsha GSVarsha requested a review from pvital March 19, 2025 16:01
pvital
pvital approved these changes Mar 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

GSVarsha added 9 commits March 20, 2025 16:45
@GSVarsha
feat: Add instrumentation to Spyne
2ab9c41 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
test(spyne): Added initial tests for spyne
41a3338 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
instrumentation(spyne): Handle errors and support custom headers
01b120e 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
test(spyne): Add tests for error handling and custom headers
087b01b 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
chore(spyne): Add spyne to requirements
ddd8c4a 
- Spyne only supports python < 3.12

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
chore(spyne): Handle repetitive code
244d67e 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
style(spyne): Add typehints
4ed457c 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
spyne: Add support for UDC
9220dd1 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
spyne: rpc-server adaptation
43e8cac 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha force-pushed the spyne_instrumentation branch from eecc4a4 to 43e8cac Compare March 20, 2025 11:15
@GSVarsha GSVarsha merged commit 06b545a into main Mar 20, 2025
2 checks passed
@GSVarsha GSVarsha deleted the spyne_instrumentation branch March 20, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvital pvital pvital approved these changes

@CagriYonca CagriYonca CagriYonca approved these changes

Assignees

@GSVarsha GSVarsha

Labels

Review & Merge

Projects

None yet

Milestone

H1-2025

Development

Successfully merging this pull request may close these issues.

3 participants

@GSVarsha @pvital @CagriYonca