docs: better multiversion support for docs v2#2568
Conversation
|
Visual regression report✅ No changes.
Baselines come from the |
817d7d2 to
d14ada1
Compare
cf96591 to
e713885
Compare
d14ada1 to
c60e824
Compare
matyasf
left a comment
There was a problem hiding this comment.
- The "If you are viewing the v11.7 version, switch to v11.6 to see the examples working correctly." text in the legacy/new theme overrides is not needed anymore since the switch is automatic.
- The message "This page always displays the latest version of the documentation" is not clear what it means. I would rephrase it to "This page is made for the latest version (v${major.minor})) of InstUI). Also the linked page https://instructure.design/pr-preview/pr-2568/v11_7/multi-version-system is way too detailed for our users, can you make a new page under Guides that explains the multi version stuff for users? We just need that components are now versioned, the import paths, and what versions work with which theming engine.
- I would not include the Component version selector for non-component pages where it does nothing
- +1: How about displaying components with the "Light" theme when switching to v11.7, since this is now the recommended theme?
e713885 to
ced0fb5
Compare
c60e824 to
7e3bad3
Compare
7e3bad3 to
a04f8e7
Compare
matyasf
left a comment
There was a problem hiding this comment.
Nice work, I like these changes a lot!
a04f8e7 to
9618859
Compare
|
|
||
| - **`v2`** (library `v11_7` and newer) supports themes built on the new token system. The legacy Canvas looks are preserved (re-implemented on the new engine) and two brand-new themes are added: | ||
|
|
||
| - `legacyCanvas` — same visual style as the old `canvas`, but on the new engine |
There was a problem hiding this comment.
This lists the v2 legacy themes as legacyCanvas / legacyCanvasHighContrast, but the new-theme-overrides page (v2) uses theme={canvas} throughout, and the docs Theme selector labels the v2 theme as canvas (legacy). Are the real v2 theme keys actually canvas / canvasHighContrast (shown as "(legacy)") rather than legacyCanvas / legacyCanvasHighContrast? If so the names here are misleading.
| <Table.RowHeader>TableRowHeader — deeppink</Table.RowHeader> | ||
| <Table.Cell>TableCell — unchanged</Table.Cell> | ||
| </Table.Row> | ||
| <Table.Row> |
There was a problem hiding this comment.
Minor: this <Table.Row> is over-indented (extra leading spaces), and both Table.ColHeaders above share the same label and a copy-pasted id pattern (h-row / h-col). Quick tidy since it renders as an example.
| <Alert variant="info" margin="xx-large 0"> | ||
| This page is made for the latest version ( | ||
| {this.getLatestMinorVersion()?.replace('_', '.')}) of InstUI.{' '} | ||
| <Link href="component-versioning"> |
There was a problem hiding this comment.
This (and the same <Link href="component-versioning"> in Document/index.tsx) uses a bare relative href. Does it resolve correctly from a versioned URL like /v11_7/Alert — navigating within the SPA rather than triggering a full reload — given the deploy-base + v11_X prefix routing? Worth a quick check.
6770bb9 to
c22a20d
Compare
1c6da87 to
01baa9e
Compare
…ponent versioning guide page
…uide and bring up usage section on component pages
…# before navigateTo so markdown links produce clean URLs
eb79668 to
fdbbe53
Compare
…orrectly merged description
matyasf
left a comment
There was a problem hiding this comment.
nice work, the whole documentation is much better understandable now!
INSTUI-5031
Summary
v11.6option in the Component version Select is labeledv11.6 (legacy theming)Co-Authored-By: 🤖 Claude