feat: add functionality to list app modules with credentials#56
feat: add functionality to list app modules with credentials#56Patrik Simek (patriksimek) merged 9 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an SDK endpoint to list Make app modules that require credentials (including required credential types/scopes), with corresponding MCP tool exposure and test coverage.
Changes:
- Added
CredentialRequests.listAppModulesWithCredentials(appName, appVersion)and theAppModuleWithCredentialsresponse type. - Exported the new response type from the package entrypoint.
- Added unit + integration tests and a JSON mock fixture for the new endpoint.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/endpoints/credential-requests.ts |
Introduces AppModuleWithCredentials type and the listAppModulesWithCredentials API call. |
src/index.ts |
Re-exports AppModuleWithCredentials for public consumption. |
src/endpoints/credential-requests.mcp.ts |
Adds an MCP tool wrapper for listing app modules with credentials. |
test/mocks/credential-requests/list-app-modules-with-credentials.json |
Provides mock API payload for unit testing. |
test/credential-requests.spec.ts |
Adds unit tests validating URL construction + URL-encoding for SDK apps. |
test/credential-requests.integration.test.ts |
Adds integration test to validate real API shape for a public app. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add minItems/maxItems to JSONSchema (already used by tool defs) and correct minLength/maxLength docs to be string-only per JSON Schema spec. - Align integration test assertion with AppModuleWithCredentials.scope being optional for non-OAuth credential types. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adds an SDK endpoint to list Make app modules that require credentials (including required credential types/scopes), with corresponding MCP tool exposure and test coverage.