-
Notifications
You must be signed in to change notification settings - Fork 9
chore: refined tool types and eslint config #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,8 @@ export type JSONSchema = { | |
| type?: 'object' | 'string' | 'number' | 'boolean' | 'array' | 'null'; | ||
| /** Properties definition for object types */ | ||
| properties?: Record<string, JSONSchema>; | ||
| /** Schemas for properties whose names match a regex pattern (object types) */ | ||
| patternProperties?: Record<string, JSONSchema>; | ||
| /** Required property names for object types */ | ||
| required?: string[]; | ||
| /** Items schema for array types */ | ||
|
|
@@ -177,7 +179,7 @@ export type MakeTool = { | |
| * @param args The input arguments matching the inputSchema | ||
| * @returns Promise resolving to the operation result | ||
| */ | ||
| execute: (make: Make, args?: Record<string, JSONValue>) => Promise<JSONValue>; | ||
| execute(make: Make, args: Record<string, JSONValue>): Promise<JSONValue>; | ||
| }; | ||
|
Comment on lines
181
to
183
|
||
|
|
||
| /** | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is now being updated, but unlike the other
*.tools.tsmodules it still exports an untypedtoolsarray (noMakeTool[]annotation). That makes it easier for tool objects here to drift from theMakeToolcontract without TypeScript catching it. Consider importingMakeTooland declaringexport const tools: MakeTool[] = [...]for consistency with the rest ofsrc/endpoints/*/*.tools.ts.