add validation_every variable to torch trainer - #435
Draft
jarlsondre wants to merge 3 commits into
Draft
Conversation
matbun
requested changes
Jul 14, 2025
matbun
left a comment
matbun
left a comment
Collaborator
There was a problem hiding this comment.
I would not change the suffix to *_interval
matbun
reviewed
Jul 14, 2025
Comment on lines
+372
to
+375
| "Ray is activated, but 'validation_every' is not set to one. Keep in mind" | ||
| " that the validation metrics are used for tuning, so this could lead" | ||
| " to suboptimal results." | ||
| ) |
Collaborator
There was a problem hiding this comment.
here I would emphasize more the fact that this flag influences the reporting frequency of ray, which has implications when tuning (and not only)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to have a variable called
validation_every, but this has since been removed as it was unused. We still have something calledtest_every, however.Recently, however, we received a request from a use case to reimplement this behavior, so this PR adds it back to the project.
One of the potential problems with this is that now the user has to specifically set the
validation_everyvariable to 1 for any validation to happen, as it defaults toNone. This might be a bit annoying, since it kinda breaks the API. Not a huge change though, but worth considering if there is a better way to do it.