Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lib/committee/test/methods.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ def assert_request_schema_confirm(except: {})
schema_validator.request_validate(request_object)
end
end

increment_assertion_count
end

def assert_response_schema_confirm(expected_status = nil)
Expand All @@ -46,6 +48,8 @@ def assert_response_schema_confirm(expected_status = nil)
end

schema_validator.response_validate(status, headers, [body], true) if validate_response?(status)

increment_assertion_count
end

def committee_options
Expand Down Expand Up @@ -90,6 +94,13 @@ def old_behavior

private

# assert_*_schema_confirm signal failure by raising, not via `assert`,
# so Minitest would report "Test is missing assertions" on success.
# Bump the counter explicitly; no-op outside Minitest (e.g. RSpec).
def increment_assertion_count
Comment thread
geemus marked this conversation as resolved.
assert true if respond_to?(:assertions)
end

# Temporarily adds dummy values for excepted parameters during validation
# @see ExceptParameter
def with_except_params(except)
Expand Down
16 changes: 16 additions & 0 deletions test/test/methods_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,14 @@ def response_data
assert_request_schema_confirm
end

it "increments the Minitest assertion count on success" do
@app = new_rack_app
get "/characters"
before_count = assertions
assert_request_schema_confirm
assert_equal before_count + 1, assertions
end

it "not exist required" do
@app = new_rack_app
get "/validate", { "query_string" => "query", "query_integer_list" => [1, 2] }
Expand Down Expand Up @@ -397,6 +405,14 @@ def response_data
assert_response_schema_confirm(200)
end

it "increments the Minitest assertion count on success" do
@app = new_rack_app(JSON.generate(@correct_response))
get "/characters"
before_count = assertions
assert_response_schema_confirm(200)
assert_equal before_count + 1, assertions
end

it "detects an invalid response Content-Type" do
@app = new_rack_app(JSON.generate([@correct_response]), {})
get "/characters"
Expand Down