Skip to content

Increment Minitest assertion count in assert_schema_conform methods #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geemus merged 2 commits into from
Apr 12, 2026
+27 −0
Merged

Increment Minitest assertion count in assert_schema_conform methods #473

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e019b4
Increment Minitest assertion count in assert_schema_conform methods
ursm Apr 6, 2026
78e643c
Address review feedback: add comment and regression tests
ursm Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/committee/test/methods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ def assert_request_schema_confirm(except: {})
schema_validator.request_validate(request_object)
end
end

increment_assertion_count
end

def assert_response_schema_confirm(expected_status = nil)
Expand All @@ -46,6 +48,8 @@ def assert_response_schema_confirm(expected_status = nil)
end

schema_validator.response_validate(status, headers, [body], true) if validate_response?(status)

increment_assertion_count
end

def committee_options
Expand Down Expand Up @@ -90,6 +94,10 @@ def old_behavior

private

def increment_assertion_count
Comment thread
geemus marked this conversation as resolved.
assert true if respond_to?(:assertions)
end

# Temporarily adds dummy values for excepted parameters during validation
# @see ExceptParameter
def with_except_params(except)
Expand Down