-
Notifications
You must be signed in to change notification settings - Fork 27
feat: implement 'locate-resource' command for resource-to-module mapping #1081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AshokThangavel
wants to merge
11
commits into
intersystems:main
Choose a base branch
from
AshokThangavel:feat/locate-command
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
cc88cbd
feat: implement 'locate' command for resource-to-module mapping
AshokThangavel 85019bc
docs: Add changelog entry
AshokThangavel b11a1db
# Refactor: rename locate command and clarify error messaging
AshokThangavel c53ff92
refactor: Method name updated
AshokThangavel 370d931
updated unit test code and changelog
AshokThangavel c292317
Merge branch 'main' into feat/locate-command
AshokThangavel 18a0425
Merge branch 'main' into feat/locate-command
AshokThangavel 629307f
Merge branch 'main' into feat/locate-command
AshokThangavel 4b2ee0b
Merge branch 'main' into feat/locate-command
AshokThangavel 53673a3
Merge branch 'feat/locate-command' of https://github.com/AshokThangav…
AshokThangavel 037df5c
Merge branch 'main' into feat/locate-command
AshokThangavel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -329,4 +329,23 @@ Method TestUninstallWithoutModuleName() | |
| do $$$AssertNotTrue(exists, "Module removed successfully.") | ||
| } | ||
|
|
||
| Method TestLocateCommand() | ||
| { | ||
| do $$$LogMessage("Testing 'loc' alias with .inc resource") | ||
| set status = ..RunCommand("loc %IPM.Common.inc") | ||
|
||
| do $$$AssertStatusOK(status, "Alias 'loc' executed successfully") | ||
|
|
||
| do $$$LogMessage("Testing 'locate' command with .cls resource") | ||
| set status = ..RunCommand("locate %IPM.Main.cls") | ||
| do $$$AssertStatusOK(status, "Command 'locate' executed successfully") | ||
|
|
||
| do $$$LogMessage("Testing locate with non-existing resource") | ||
| set status = ..RunCommand("locate Test.Sample.inc") | ||
| do $$$AssertStatusOK(status, "Gracefully handled non-existing resource") | ||
|
|
||
| do $$$LogMessage("Testing locate without required argument") | ||
| set status = ..RunCommand("locate") | ||
| do $$$AssertStatusNotOK(status, "Handled missing argument") | ||
| } | ||
|
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: capitalize "implement" and move to 0.10.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to
1.10.7release. Thank you!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you need to pull from main to resolve the conflict here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pulled from main and resolved the conflicts as well. Thank you!