fix(deps): adopt current stable native admob SDKs#830
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~830 Documentation is deployed and generated using docs.page. |
dylancom
left a comment
dylancom
left a comment
There was a problem hiding this comment.
We can also bump the UMP sdk's.
iOS 3.1.0: https://developers.google.com/admob/ios/privacy/download
Android: 4.0.0 (breaking?) Increased the minimum Android API level to 23 https://developers.google.com/admob/android/privacy/release-notes
|
May not be a break as 23 is still very very old, likely already within our min react-native window. Will check |
|
Indeed I see we already have |
|
Yeah, looks like API23 has been the minimum for react-native since 0.74, I'm pretty sure we're good: react-native-community/discussions-and-proposals#740 For reference, the next bump they did was to API24 in react-native 0.76 Here's the full table - current minSdk for react-native is still API24 / Android 7 since react-native 0.76 |
the native SDKs are just patch releases, but I saw notices in the native logs complaining they were not up to date, so I found the latest versions in release notes and adopted them
mikehardy
force-pushed
the
@mikehardy/update-native-sdks
branch
from
d41be35 to
883bae4
Compare
|
I've rebased the commits from the prior PR out and have this up to date with main now I updated UMP as well (good catch), we collectively verified it's within our existing version range so patch release should be good I verified via local testing that there are no event-timing issues like I mentioned I saw with #831 - so this is good to go and appears to serve as a good baseline for testing on #831 whenever I have time to pick that up again (or if someone else does) Ready to go I think |
| COCOAPODS: 1.16.2 | ||
| COCOAPODS: 1.15.2 |
There was a problem hiding this comment.
I was having some issues locally since my local cocoapods is 1.16.2
But react-native-test-app uses a Gemfile and locally installs with 1.15.2
I attempted to clear out the Gemfile and Gemfile.lock in a commit that I eventually dropped, it was too much hassle
So this version number flapped (went back and forth) in the meantime, while I was trying that.
This one is the result of the easy path though, yarn && yarn tests:install && yarn tests:ios:run works out of the box now (I tested via git clean -d -x -f . to start fresh) which is the most important thing
| .idea/ | ||
| .vs/ | ||
| .xcode.env | ||
| ios/.xcode.env |
There was a problem hiding this comment.
I'm not sure the change is strictly necessary but it is semantically the same
The main thing is the existing file was deleted. It's contents referred to my personal file system path which is not the most useful thing for anyone else 😆
It should have never been committed and the delete is fix for that
|
🎉 This PR is included in version 16.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
Description
Does what it says in the title
also deleted a personal-developer-only file that shouldn't have been in the repo and .gitignore'd it,
and switched to relying on system installed cocoapods version vs the Gemfile - it was out of date and updating it is pointless workRelated issues
Only the last 3 commits here are the new PR, it is based on the existing PR that finishes TurboModules work for Android:
...after that's merged I'll rebase those commits out of here and re-push
Reviewers should review commit by commit, and just look at the last 3
Release Summary
fix release via conventional commits
Checklist
and followed the process outlined there for submitting PRs.
AndroidiOSe2etests added or updated in__tests__e2e__jesttests added or updated in__tests__Test Plan
Everything seemed to work fine and it eliminated native warnings for me that the SDKs were out of date
Think
react-native-google-mobile-adsis great? Please consider supporting the project with any of the below:Invertaseon Twitter