Feature/c3d updates by petersteneteg · Pull Request #285 · inviwo/modules

petersteneteg · 2026-08-31T13:31:44Z

No description provided.

github-actions · 2026-08-31T18:17:57Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v19.1.7) reports: 10 concern(s)

misc/c3d/include/inviwo/c3d/datastructures/c3ddata.h:40:26: warning: [cppcoreguidelines-special-member-functions]

class 'C3D' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor
```
   40 | class IVW_MODULE_C3D_API C3D : public ezc3d::c3d {
      |                          ^
```

misc/c3d/src/datastructures/c3ddata.cpp:76:9: warning: [misc-const-correctness]

variable 'pointsInfo' of type 'ezc3d::DataNS::Points3dNS::Info' can be declared 'const'

   76 |         ezc3d::DataNS::Points3dNS::Info pointsInfo{*this};
      |         ^
      |                                         const

misc/c3d/src/datastructures/c3ddata.cpp:77:9: warning: [misc-const-correctness]

variable 'analogsInfo' of type 'ezc3d::DataNS::AnalogsNS::Info' can be declared 'const'

   77 |         ezc3d::DataNS::AnalogsNS::Info analogsInfo{*this};
      |         ^
      |                                        const

misc/c3d/src/datastructures/c3ddata.cpp:78:9: warning: [misc-const-correctness]

variable 'rotationsInfo' of type 'ezc3d::DataNS::RotationNS::Info' can be declared 'const'

   78 |         ezc3d::DataNS::RotationNS::Info rotationsInfo{*this};
      |         ^
      |                                         const

misc/c3d/src/datastructures/c3ddata.cpp:99:30: warning: [bugprone-narrowing-conversions]

narrowing conversion from 'unsigned long' to signed type 'off_type' (aka 'long long') is implementation-defined
```
   99 |                 stream.seekg(sizeof(float) * _header->nbAnalogByFrame() * _header->nbAnalogs(),
      |                              ^
```

misc/c3d/src/datastructures/c3ddata.cpp:116:13: warning: [misc-const-correctness]

variable 'fileSize' of type 'std::streampos' (aka 'fpos<__mbstate_t>') can be declared 'const'

  116 |             std::streampos fileSize = stream.seekg(0, std::ios::end).tellg();
      |             ^
      |                            const

misc/c3d/src/datastructures/c3ddata.cpp:117:13: warning: [misc-const-correctness]

variable 'targetPos' of type 'int' can be declared 'const'

  117 |             int targetPos(static_cast<int>(rotationsInfo.dataStart() - 1) * 512);
      |             ^
      |                 const

misc/c3d/src/datastructures/c3ddatatraits.cpp:44:10: warning: [readability-qualified-auto]

'auto &name' can be declared as 'const auto &name'
```
   44 |     for (auto& name : data.pointNames()) {
      |          ^
      |          const 
```

misc/c3d/src/io/c3dreader.cpp:63:31: warning: [bugprone-branch-clone]

repeated branch body in conditional chain

   63 |     if (key == "ReadAnalogs") {
      |                               ^
/home/runner/work/modules/modules/inviwo/misc/c3d/src/io/c3dreader.cpp:65:6: note: end of the original
   65 |     } else if (key == "ReadRotations") {
      |      ^
/home/runner/work/modules/modules/inviwo/misc/c3d/src/io/c3dreader.cpp:65:40: note: clone 1 starts here
   65 |     } else if (key == "ReadRotations") {
      |                                        ^

misc/c3d/src/processors/c3dtomesh.cpp:114:30: warning: [cppcoreguidelines-pro-type-static-cast-downcast]

do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead

  114 |             const auto* sp = static_cast<const StringProperty*>(prop);
      |                              ^~~~~~~~~~~
      |                              dynamic_cast

Have any feedback or feature suggestions? Share it here.

github-actions

Cpp-linter Review

Used clang-tidy v19.1.7

Click here for the full clang-tidy patch

diff --git a/misc/c3d/src/datastructures/c3ddata.cpp b/misc/c3d/src/datastructures/c3ddata.cpp
index 8ac2f81..c9c1b21 100644
--- a/misc/c3d/src/datastructures/c3ddata.cpp
+++ b/misc/c3d/src/datastructures/c3ddata.cpp
@@ -76,3 +76,3 @@ C3D::C3D(const std::filesystem::path& path, Options options) : ezc3d::c3d{} {
-        ezc3d::DataNS::Points3dNS::Info pointsInfo{*this};
-        ezc3d::DataNS::AnalogsNS::Info analogsInfo{*this};
-        ezc3d::DataNS::RotationNS::Info rotationsInfo{*this};
+        const ezc3d::DataNS::Points3dNS::Info pointsInfo{*this};
+        const ezc3d::DataNS::AnalogsNS::Info analogsInfo{*this};
+        const ezc3d::DataNS::RotationNS::Info rotationsInfo{*this};
@@ -116,2 +116,2 @@ C3D::C3D(const std::filesystem::path& path, Options options) : ezc3d::c3d{} {
-            std::streampos fileSize = stream.seekg(0, std::ios::end).tellg();
-            int targetPos(static_cast<int>(rotationsInfo.dataStart() - 1) * 512);
+            const std::streampos fileSize = stream.seekg(0, std::ios::end).tellg();
+            const int targetPos(static_cast<int>(rotationsInfo.dataStart() - 1) * 512);
diff --git a/misc/c3d/src/datastructures/c3ddatatraits.cpp b/misc/c3d/src/datastructures/c3ddatatraits.cpp
index 6e537ea..0342fb8 100644
--- a/misc/c3d/src/datastructures/c3ddatatraits.cpp
+++ b/misc/c3d/src/datastructures/c3ddatatraits.cpp
@@ -44 +44 @@ Document DataTraits<C3D>::info(const C3D& data) {
-    for (auto& name : data.pointNames()) {
+    for (const auto& name : data.pointNames()) {
diff --git a/misc/c3d/src/processors/c3dtomesh.cpp b/misc/c3d/src/processors/c3dtomesh.cpp
index a63e93c..ece3f23 100644
--- a/misc/c3d/src/processors/c3dtomesh.cpp
+++ b/misc/c3d/src/processors/c3dtomesh.cpp
@@ -114 +114 @@ void C3DToMesh::process() {
-            const auto* sp = static_cast<const StringProperty*>(prop);
+            const auto* sp = dynamic_cast<const StringProperty*>(prop);

Have any feedback or feature suggestions? Share it here.

github-actions · 2026-08-31T18:17:59Z


 namespace inviwo {

+class IVW_MODULE_C3D_API C3D : public ezc3d::c3d {


clang-tidy diagnostic

misc/c3d/include/inviwo/c3d/datastructures/c3ddata.h:40:26: warning: [cppcoreguidelines-special-member-functions]

class 'C3D' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor

40 | class IVW_MODULE_C3D_API C3D : public ezc3d::c3d { | ^

github-actions · 2026-08-31T18:17:59Z

+        ezc3d::DataNS::Points3dNS::Info pointsInfo{*this};
+        ezc3d::DataNS::AnalogsNS::Info analogsInfo{*this};
+        ezc3d::DataNS::RotationNS::Info rotationsInfo{*this};


clang-tidy diagnostics

variable 'pointsInfo' of type 'ezc3d::DataNS::Points3dNS::Info' can be declared 'const' [misc-const-correctness]

variable 'analogsInfo' of type 'ezc3d::DataNS::AnalogsNS::Info' can be declared 'const' [misc-const-correctness]

variable 'rotationsInfo' of type 'ezc3d::DataNS::RotationNS::Info' can be declared 'const' [misc-const-correctness]

Suggested change

ezc3d::DataNS::Points3dNS::Info pointsInfo{*this};

ezc3d::DataNS::AnalogsNS::Info analogsInfo{*this};

ezc3d::DataNS::RotationNS::Info rotationsInfo{*this};

const ezc3d::DataNS::Points3dNS::Info pointsInfo{*this};

const ezc3d::DataNS::AnalogsNS::Info analogsInfo{*this};

const ezc3d::DataNS::RotationNS::Info rotationsInfo{*this};

github-actions · 2026-08-31T18:17:59Z

+            std::streampos fileSize = stream.seekg(0, std::ios::end).tellg();
+            int targetPos(static_cast<int>(rotationsInfo.dataStart() - 1) * 512);


clang-tidy diagnostics

variable 'fileSize' of type 'std::streampos' (aka 'fpos<__mbstate_t>') can be declared 'const' [misc-const-correctness]

variable 'targetPos' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

std::streampos fileSize = stream.seekg(0, std::ios::end).tellg();

int targetPos(static_cast<int>(rotationsInfo.dataStart() - 1) * 512);

const std::streampos fileSize = stream.seekg(0, std::ios::end).tellg();

const int targetPos(static_cast<int>(rotationsInfo.dataStart() - 1) * 512);

github-actions · 2026-08-31T18:17:59Z

+            if (options.readAnalogs) {
+                f.add(ezc3d::DataNS::AnalogsNS::Analogs(*this, stream, analogsInfo));
+            } else {
+                stream.seekg(sizeof(float) * _header->nbAnalogByFrame() * _header->nbAnalogs(),


clang-tidy diagnostic

misc/c3d/src/datastructures/c3ddata.cpp:99:30: warning: [bugprone-narrowing-conversions]

narrowing conversion from 'unsigned long' to signed type 'off_type' (aka 'long long') is implementation-defined

99 | stream.seekg(sizeof(float) * _header->nbAnalogByFrame() * _header->nbAnalogs(), | ^

github-actions · 2026-08-31T18:18:00Z

+
+    utildoc::TableBuilder tb2(doc.handle(), P::end());
+    tb2(H(fmt::format("Points ({})", data.header().nb3dPoints())));
+    for (auto& name : data.pointNames()) {


clang-tidy diagnostics

'auto &name' can be declared as 'const auto &name' [readability-qualified-auto]

Suggested change

for (auto& name : data.pointNames()) {

for (const auto& name : data.pointNames()) {

github-actions · 2026-08-31T18:18:00Z

+    return false;
+}
+std::any C3DReader::getOption(std::string_view key) {
+    if (key == "ReadAnalogs") {


clang-tidy diagnostic

misc/c3d/src/io/c3dreader.cpp:63:31: warning: [bugprone-branch-clone]

repeated branch body in conditional chain

63 | if (key == "ReadAnalogs") { | ^ /home/runner/work/modules/modules/inviwo/misc/c3d/src/io/c3dreader.cpp:65:6: note: end of the original 65 | } else if (key == "ReadRotations") { | ^ /home/runner/work/modules/modules/inviwo/misc/c3d/src/io/c3dreader.cpp:65:40: note: clone 1 starts here 65 | } else if (key == "ReadRotations") { | ^

github-actions · 2026-08-31T18:18:00Z

+        pointIndices.assign_range(std::views::iota(0uz, nbPoints));
+    } else {
+        for (const auto* prop : pointSelection_) {
+            const auto* sp = static_cast<const StringProperty*>(prop);


clang-tidy diagnostics

do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast]

Suggested change

const auto* sp = static_cast<const StringProperty*>(prop);

const auto* sp = dynamic_cast<const StringProperty*>(prop);

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v19.1.7

Click here for the full clang-tidy patch

diff --git a/misc/c3d/src/datastructures/c3ddata.cpp b/misc/c3d/src/datastructures/c3ddata.cpp
index 8ac2f81..c9c1b21 100644
--- a/misc/c3d/src/datastructures/c3ddata.cpp
+++ b/misc/c3d/src/datastructures/c3ddata.cpp
@@ -76,3 +76,3 @@ C3D::C3D(const std::filesystem::path& path, Options options) : ezc3d::c3d{} {
-        ezc3d::DataNS::Points3dNS::Info pointsInfo{*this};
-        ezc3d::DataNS::AnalogsNS::Info analogsInfo{*this};
-        ezc3d::DataNS::RotationNS::Info rotationsInfo{*this};
+        const ezc3d::DataNS::Points3dNS::Info pointsInfo{*this};
+        const ezc3d::DataNS::AnalogsNS::Info analogsInfo{*this};
+        const ezc3d::DataNS::RotationNS::Info rotationsInfo{*this};
@@ -116,2 +116,2 @@ C3D::C3D(const std::filesystem::path& path, Options options) : ezc3d::c3d{} {
-            std::streampos fileSize = stream.seekg(0, std::ios::end).tellg();
-            int targetPos(static_cast<int>(rotationsInfo.dataStart() - 1) * 512);
+            const std::streampos fileSize = stream.seekg(0, std::ios::end).tellg();
+            const int targetPos(static_cast<int>(rotationsInfo.dataStart() - 1) * 512);
diff --git a/misc/c3d/src/datastructures/c3ddatatraits.cpp b/misc/c3d/src/datastructures/c3ddatatraits.cpp
index 6e537ea..0342fb8 100644
--- a/misc/c3d/src/datastructures/c3ddatatraits.cpp
+++ b/misc/c3d/src/datastructures/c3ddatatraits.cpp
@@ -44 +44 @@ Document DataTraits<C3D>::info(const C3D& data) {
-    for (auto& name : data.pointNames()) {
+    for (const auto& name : data.pointNames()) {
diff --git a/misc/c3d/src/processors/c3dtomesh.cpp b/misc/c3d/src/processors/c3dtomesh.cpp
index a63e93c..ece3f23 100644
--- a/misc/c3d/src/processors/c3dtomesh.cpp
+++ b/misc/c3d/src/processors/c3dtomesh.cpp
@@ -114 +114 @@ void C3DToMesh::process() {
-            const auto* sp = static_cast<const StringProperty*>(prop);
+            const auto* sp = dynamic_cast<const StringProperty*>(prop);

Have any feedback or feature suggestions? Share it here.

github-actions · 2026-09-01T14:46:42Z


 namespace inviwo {

+class IVW_MODULE_C3D_API C3D : public ezc3d::c3d {


clang-tidy diagnostic

misc/c3d/include/inviwo/c3d/datastructures/c3ddata.h:40:26: warning: [cppcoreguidelines-special-member-functions]

class 'C3D' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor

40 | class IVW_MODULE_C3D_API C3D : public ezc3d::c3d { | ^

github-actions · 2026-09-01T14:46:42Z

+        ezc3d::DataNS::Points3dNS::Info pointsInfo{*this};
+        ezc3d::DataNS::AnalogsNS::Info analogsInfo{*this};
+        ezc3d::DataNS::RotationNS::Info rotationsInfo{*this};


clang-tidy diagnostics

variable 'pointsInfo' of type 'ezc3d::DataNS::Points3dNS::Info' can be declared 'const' [misc-const-correctness]

variable 'analogsInfo' of type 'ezc3d::DataNS::AnalogsNS::Info' can be declared 'const' [misc-const-correctness]

variable 'rotationsInfo' of type 'ezc3d::DataNS::RotationNS::Info' can be declared 'const' [misc-const-correctness]

Suggested change

ezc3d::DataNS::Points3dNS::Info pointsInfo{*this};

ezc3d::DataNS::AnalogsNS::Info analogsInfo{*this};

ezc3d::DataNS::RotationNS::Info rotationsInfo{*this};

const ezc3d::DataNS::Points3dNS::Info pointsInfo{*this};

const ezc3d::DataNS::AnalogsNS::Info analogsInfo{*this};

const ezc3d::DataNS::RotationNS::Info rotationsInfo{*this};

github-actions · 2026-09-01T14:46:42Z

+            std::streampos fileSize = stream.seekg(0, std::ios::end).tellg();
+            int targetPos(static_cast<int>(rotationsInfo.dataStart() - 1) * 512);


clang-tidy diagnostics

variable 'fileSize' of type 'std::streampos' (aka 'fpos<__mbstate_t>') can be declared 'const' [misc-const-correctness]

variable 'targetPos' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

std::streampos fileSize = stream.seekg(0, std::ios::end).tellg();

int targetPos(static_cast<int>(rotationsInfo.dataStart() - 1) * 512);

const std::streampos fileSize = stream.seekg(0, std::ios::end).tellg();

const int targetPos(static_cast<int>(rotationsInfo.dataStart() - 1) * 512);

github-actions · 2026-09-01T14:46:42Z

+            if (options.readAnalogs) {
+                f.add(ezc3d::DataNS::AnalogsNS::Analogs(*this, stream, analogsInfo));
+            } else {
+                stream.seekg(sizeof(float) * _header->nbAnalogByFrame() * _header->nbAnalogs(),


clang-tidy diagnostic

misc/c3d/src/datastructures/c3ddata.cpp:99:30: warning: [bugprone-narrowing-conversions]

narrowing conversion from 'unsigned long' to signed type 'off_type' (aka 'long long') is implementation-defined

99 | stream.seekg(sizeof(float) * _header->nbAnalogByFrame() * _header->nbAnalogs(), | ^

github-actions · 2026-09-01T14:46:43Z

+
+    utildoc::TableBuilder tb2(doc.handle(), P::end());
+    tb2(H(fmt::format("Points ({})", data.header().nb3dPoints())));
+    for (auto& name : data.pointNames()) {


clang-tidy diagnostics

'auto &name' can be declared as 'const auto &name' [readability-qualified-auto]

Suggested change

for (auto& name : data.pointNames()) {

for (const auto& name : data.pointNames()) {

github-actions · 2026-09-01T14:46:43Z

+    return false;
+}
+std::any C3DReader::getOption(std::string_view key) {
+    if (key == "ReadAnalogs") {


clang-tidy diagnostic

misc/c3d/src/io/c3dreader.cpp:63:31: warning: [bugprone-branch-clone]

repeated branch body in conditional chain

63 | if (key == "ReadAnalogs") { | ^ /home/runner/work/modules/modules/inviwo/misc/c3d/src/io/c3dreader.cpp:65:6: note: end of the original 65 | } else if (key == "ReadRotations") { | ^ /home/runner/work/modules/modules/inviwo/misc/c3d/src/io/c3dreader.cpp:65:40: note: clone 1 starts here 65 | } else if (key == "ReadRotations") { | ^

github-actions · 2026-09-01T14:46:43Z

+        pointIndices.assign_range(std::views::iota(0uz, nbPoints));
+    } else {
+        for (const auto* prop : pointSelection_) {
+            const auto* sp = static_cast<const StringProperty*>(prop);


clang-tidy diagnostics

do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast]

Suggested change

const auto* sp = static_cast<const StringProperty*>(prop);

const auto* sp = dynamic_cast<const StringProperty*>(prop);

martinfalk approved these changes Aug 31, 2026

View reviewed changes

github-actions Bot previously requested changes Aug 31, 2026

View reviewed changes

petersteneteg added 9 commits September 1, 2026 14:06

c3d: fixes and new sequence source

ad915c4

C3D: more sequence support

77a9a59

C3D: warning fix

7e20649

C3D: wrap data in our own class. To be able to to some more tweaks,

3267047

C3D: added options to skip reading analogs and rotations

a487265

C3D: transformpoints to poolprocessor

372e202

C3D: mesh to source avoid bnl invalidations

2796e64

C3D: faster transform points

f1a98ee

C3D: added point selection possibilities to the c3dtomesh

efff73d

petersteneteg force-pushed the feature/c3d-updates branch from d2b1ca8 to efff73d Compare September 1, 2026 12:06

github-actions Bot requested changes Sep 1, 2026

View reviewed changes


		namespace inviwo {

		class IVW_MODULE_C3D_API C3D : public ezc3d::c3d {

		std::streampos fileSize = stream.seekg(0, std::ios::end).tellg();
		int targetPos(static_cast<int>(rotationsInfo.dataStart() - 1) * 512);

	for (auto& name : data.pointNames()) {
	for (const auto& name : data.pointNames()) {

	const auto* sp = static_cast<const StringProperty*>(prop);
	const auto* sp = dynamic_cast<const StringProperty*>(prop);

Uh oh!

Conversation

petersteneteg commented Aug 31, 2026

Uh oh!

github-actions Bot commented Aug 31, 2026

Cpp-Linter Report ⚠️

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v19.1.7

Uh oh!

github-actions Bot Aug 31, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

Uh oh!

github-actions Bot Aug 31, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot Aug 31, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot Aug 31, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

Uh oh!

github-actions Bot Aug 31, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot Aug 31, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

Uh oh!

github-actions Bot Aug 31, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v19.1.7

Uh oh!

github-actions Bot Sep 1, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

Uh oh!

github-actions Bot Sep 1, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot Sep 1, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot Sep 1, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

Uh oh!

github-actions Bot Sep 1, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot Sep 1, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

Uh oh!

github-actions Bot Sep 1, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!