-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(mm): add editable source_url field to model config #8997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pfannkuchensack
wants to merge
15
commits into
invoke-ai:main
Choose a base branch
from
Pfannkuchensack:feat/source_url_model_manager
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1ff9dc9
feat: add editable source_url field to model config
Pfannkuchensack 5286f6d
Merge branch 'main' into feat/source_url_model_manager
Pfannkuchensack f0420bd
Merge branch 'main' into feat/source_url_model_manager
Pfannkuchensack 9d25284
Merge branch 'main' into feat/source_url_model_manager
Pfannkuchensack 5f5f063
Merge branch 'main' into feat/source_url_model_manager
Pfannkuchensack ae358d7
fix(mm): validate source_url to prevent XSS via javascript: URI scheme
Pfannkuchensack 7da51f0
Merge branch 'main' into feat/source_url_model_manager
Pfannkuchensack e74a11e
fix(mm): harden source_url validator against non-string inputs
Pfannkuchensack 4f79260
Merge branch 'feat/source_url_model_manager' of https://github.com/Pf…
Pfannkuchensack bde8507
Merge branch 'main' into feat/source_url_model_manager
Pfannkuchensack f871c00
Merge branch 'main' into feat/source_url_model_manager
Pfannkuchensack 5bc063f
Merge branch 'main' into feat/source_url_model_manager
Pfannkuchensack b1644bc
Merge branch 'main' into feat/source_url_model_manager
Pfannkuchensack fa137a9
Chore Typegen
Pfannkuchensack 6366196
Merge branch 'main' into feat/source_url_model_manager
Pfannkuchensack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -124,6 +124,12 @@ export const ModelEdit = memo(({ modelConfig }: Props) => { | |
| <Textarea {...form.register('description')} minH={32} /> | ||
| </FormControl> | ||
| </Flex> | ||
| <Flex gap="4" alignItems="center"> | ||
| <FormControl flexDir="column" alignItems="flex-start" gap={1}> | ||
| <FormLabel>{t('modelManager.sourceUrl')}</FormLabel> | ||
| <Input {...form.register('source_url')} size="md" placeholder="https://" /> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should add
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
| </FormControl> | ||
| </Flex> | ||
| <Heading as="h3" fontSize="md" mt="4"> | ||
| {t('modelManager.modelSettings')} | ||
| </Heading> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT rose a concern for this and
model_records_base.py, if you call.startswith()inside amode="before"validator without first checking the raw value is a string. APATCHbody like{"source_url": 123}will hitAttributeErrorinstead of a normal validation error, which is likely to surface as a500instead of a clean4xx.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.