Skip to content

Add clearing code to credit transfers - #920

Merged
samlown merged 3 commits into
release-0.504.0from
add-credit-transfer-clearing-code
Aug 5, 2026
Merged

Add clearing code to credit transfers#920
samlown merged 3 commits into
release-0.504.0from
add-credit-transfer-clearing-code

Conversation

@samlown

@samlown samlown commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a generic clearing identifier to pay.CreditTransfer for national bank or branch clearing codes
  • use cbc.Code for the IBAN, BIC, account number, and clearing identifier fields
  • keep the descriptive bank name as a string
  • regenerate the credit transfer JSON schema

This allows formats such as OIOUBL to represent a Danish bank registration number without overloading the bank name field. The same field can also represent concepts such as UK sort codes and US routing numbers.

Testing

  • go test ./...
  • go generate .

@samlown
samlown changed the base branch from main to release-0.504.0 August 5, 2026 13:48
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.95%. Comparing base (00506a5) to head (4897d4c).
⚠️ Report is 1 commits behind head on release-0.504.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-0.504.0     #920   +/-   ##
================================================
  Coverage            94.95%   94.95%           
================================================
  Files                  327      327           
  Lines                17668    17668           
================================================
  Hits                 16777    16777           
  Misses                 549      549           
  Partials               342      342           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@samlown
samlown merged commit da8519f into release-0.504.0 Aug 5, 2026
4 checks passed
@samlown
samlown deleted the add-credit-transfer-clearing-code branch August 5, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant