fix: allow space on jsonschema tags - #147
Open
nvanheuverzwijn wants to merge 1 commit into
Open
Conversation
samlown
requested changes
Oct 7, 2024
samlown
left a comment
Contributor
There was a problem hiding this comment.
This looks useful! Thanks! I do think it would be better however to move the test outside of the mega-example to avoid updating all the fixtures.
nvanheuverzwijn
force-pushed
the
fix-allow-space-on-jsonschema-tags
branch
from
October 9, 2024 15:32
4b9dcfb to
538b528
Compare
Author
|
@samlown You are right, much cleaner that way :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to parse this golang struct:
and I realized that the
enumwere not being populated correctly. Turns out I needed to remove the space from the struct. I added a PR to trim the tags if that's something interesting for you guys. Otherwise, I will open another PR with documentation change to reflect that jsonschema should not have any space betweem each tags.I also added another enum in the test fixtures with spaces. The actual code change is here https://github.com/invopop/jsonschema/pull/147/files#diff-672d1dd2b9193c8818108f625c29ff25feaea4c1c50cc36cfda18108cba3e1b2