feat: add all_of and condition to specify a sub jsonschema as a type - #43
Open
sguiheux wants to merge 1 commit into
Open
feat: add all_of and condition to specify a sub jsonschema as a type#43sguiheux wants to merge 1 commit into
sguiheux wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
To be a little more specific than the tag: "oneof_type=string,array", I add a new one that use "all_of" and condition to specify the type of field.
With this type of struct when the content of a field ( Specification ) depends of another one, we can specify in the jsonschema the right type, and make jsonschema validation works
As it does not affect directly the type of field ( because it adds a all_of on the parent ), I do not implements this in the tags jsonschema like oneof_type, cleaner and more readable