-
Notifications
You must be signed in to change notification settings - Fork 9
feat(docs): Add comprehensive CLI documentation suite #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,12 +70,21 @@ Error: Could not find or load main class dev.ionfusion.fusion.cli.Cli | |
|
|
||
| 2. **Ensure Java 8 or later is installed:** | ||
| ```bash | ||
| # Install Amazon Corretto (recommended) | ||
| # Install Corretto (recommended) | ||
| # macOS with Homebrew: | ||
|
mtorres11 marked this conversation as resolved.
|
||
| brew install --cask corretto8 | ||
|
|
||
| # Ubuntu/Debian: | ||
| # macOS with MacPorts: | ||
| sudo port install openjdk8-corretto | ||
|
|
||
| # Ubuntu/Debian (OpenJDK): | ||
| sudo apt-get install openjdk-8-jdk | ||
|
mtorres11 marked this conversation as resolved.
|
||
|
|
||
| # Ubuntu/Debian (Corretto): | ||
| wget -O- https://apt.corretto.aws/corretto.key | sudo apt-key add - | ||
| sudo add-apt-repository 'deb https://apt.corretto.aws stable main' | ||
| sudo apt-get update | ||
| sudo apt-get install java-1.8.0-amazon-corretto-jdk | ||
| ``` | ||
|
|
||
| 3. **Check JAVA_HOME environment variable:** | ||
|
|
@@ -375,18 +384,24 @@ Data processing is slower than expected. | |
|
|
||
|
Comment on lines
+352
to
+384
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again, these bits are not CLI specific. I really don't want to end up with similar/same content in multiple documents, that increases maintenance burden. Better to cross-link generously. (Best to have fluid documents that can transclude relevent content, but that's not possible today.) |
||
| **Solutions:** | ||
|
mtorres11 marked this conversation as resolved.
|
||
|
|
||
| 1. **Use Ion binary format:** | ||
| 1. **Use efficient Fusion operations:** | ||
| ```bash | ||
| # Convert to binary for faster processing | ||
| fusion eval '(ionize_to_blob data)' > data.10n | ||
| # Use struct lookups with elt over nested access | ||
| fusion eval '(elt data "field")' # instead of (. data "field") | ||
| ``` | ||
|
Comment on lines
+387
to
+391
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we should be recommending this kind of micro-optimization. At the very least, we should have data that shows it's worth recommending, and when. |
||
|
|
||
| 2. **Optimize algorithms:** | ||
| 2. **Avoid deeply nested loops:** | ||
| ```bash | ||
| # Use built-in functions when possible | ||
| fusion require '/fusion/list' ';' eval '(map process-fn data)' | ||
| ``` | ||
|
|
||
| 3. **Optimize algorithms:** | ||
| ```bash | ||
| # Use performant operations like struct lookups | ||
| fusion require '/fusion/struct' ';' eval '(struct_get data "key")' | ||
| ``` | ||
|
|
||
| 3. **Profile with coverage tools:** | ||
| ```bash | ||
| fusion --repositories ./modules load --profile script.fusion | ||
|
|
||
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the unclear comment -- I mean we should link to the Amazon Ion official site (i.e https://amazon-ion.github.io/ion-docs/) not the Fusion one