ipfs: remove wrapping blockservice and add ToBlockServiceBlocker helper#35
Closed
Jorropo wants to merge 1 commit intoipfs-shipyard:masterfrom
Closed
ipfs: remove wrapping blockservice and add ToBlockServiceBlocker helper#35Jorropo wants to merge 1 commit intoipfs-shipyard:masterfrom
Jorropo wants to merge 1 commit intoipfs-shipyard:masterfrom
Conversation
Jorropo
commented
Jan 15, 2024
| return nbs.bs.DeleteBlock(ctx, o) | ||
| // Deprecated: Use [ToBlockServiceBlocker] and pass [blockservice.WithContentBlocker] option when constructing your blockservice. | ||
| func WrapBlockService(bs blockservice.BlockService, blocker *nopfs.Blocker) blockservice.BlockService { | ||
| return blockservice.New(bs.Blockstore(), bs.Exchange(), blockservice.WithContentBlocker(ToBlockServiceBlocker(blocker))) |
Author
There was a problem hiding this comment.
This loose other options passed in like WriteThrough or custom allowlist. Might be worth fully breaking the API. Outside of Rainbow and Kubo I don't know of nopfs consumers.
Author
|
Depends on ipfs/boxo#556 ( |
Jorropo
force-pushed
the
new-blockservice-blocker
branch
from
41a0028 to
7358813
Compare
Jorropo
force-pushed
the
new-blockservice-blocker
branch
from
7358813 to
54c62ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34