Skip to content

feat(routing/http): IPIP-518: HTTP(S) URLs in Routing V1 API #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lidel wants to merge 6 commits into
base: main
Choose a base branch
from

refactor(routing/http): preserve http-path in ToMultiaddr, extract in…

0feb195
Select commit
Loading
Failed to load commit list.
Draft

feat(routing/http): IPIP-518: HTTP(S) URLs in Routing V1 API #1051

refactor(routing/http): preserve http-path in ToMultiaddr, extract in…
0feb195
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 2, 2026 in 0s

61.96% (+0.27%) compared to f0cdbf6

View this Pull Request on Codecov

61.96% (+0.27%) compared to f0cdbf6

Details

Codecov Report

❌ Patch coverage is 82.85714% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.96%. Comparing base (f0cdbf6) to head (0feb195).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
routing/http/types/address.go 85.41% 16 Missing and 5 partials ⚠️
routing/http/contentrouter/contentrouter.go 68.96% 8 Missing and 1 partial ⚠️
routing/http/filters/filters.go 87.03% 5 Missing and 2 partials ⚠️
routing/http/contentrouter/interop.go 80.64% 3 Missing and 3 partials ⚠️
routing/http/types/json/responses.go 50.00% 2 Missing and 2 partials ⚠️
routing/http/types/record_generic.go 88.88% 2 Missing and 2 partials ⚠️
routing/http/types/ndjson/records.go 70.00% 2 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
+ Coverage   61.68%   61.96%   +0.27%     
==========================================
  Files         265      268       +3     
  Lines       26513    26804     +291     
==========================================
+ Hits        16355    16609     +254     
- Misses       8469     8495      +26     
- Partials     1689     1700      +11
Files with missing lines Coverage Δ
routing/http/client/client.go 75.60% <100.00%> (+0.06%) ⬆️
routing/http/types/ndjson/records.go 66.03% <70.00%> (+14.87%) ⬆️
routing/http/types/json/responses.go 56.66% <50.00%> (-1.03%) ⬇️
routing/http/types/record_generic.go 88.88% <88.88%> (ø)
routing/http/contentrouter/interop.go 80.64% <80.64%> (ø)
routing/http/filters/filters.go 83.21% <87.03%> (-1.56%) ⬇️
routing/http/contentrouter/contentrouter.go 56.86% <68.96%> (+2.00%) ⬆️
routing/http/types/address.go 85.41% <85.41%> (ø)

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov