WIP: Migrate Fusilli from header-only to compiled static library#192
Draft
sjain-stanford wants to merge 2 commits intomainfrom
Draft
WIP: Migrate Fusilli from header-only to compiled static library#192sjain-stanford wants to merge 2 commits intomainfrom
sjain-stanford wants to merge 2 commits intomainfrom
Conversation
Move all headers from include/ to src/ and extract inline implementations from 8 headers into corresponding .cc files to produce a STATIC library target instead of INTERFACE. - CMakeLists.txt: INTERFACE → STATIC, source glob from src/*.cc, visibility keywords INTERFACE → PUBLIC/PRIVATE, add sanitizer and coverage flags for the library target, add ARCHIVE install - New .cc files: asm_emitter, runtime, backend, compile_session, compile_command, graph, cache, external_tools - Headers trimmed to declarations only (templates stay inline) - Include paths unchanged (#include "fusilli/..." still works) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add direct includes to all .cc files for IWYU compliance per misc-include-cleaner: project headers (logging, cache, handle, node types, attribute types), IREE headers (modules/hal/types.h, modules/hal/debugging.h, base/config.h), and standard library headers (utility, memory, string, etc). Disable llvm-header-guard in .clang-tidy config — the check computes machine-specific absolute-path guards which conflict with the project's intentional short guard style (FUSILLI_*). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sjain-stanford
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include/tosrc/and extract inline implementations from 8 headers into.ccfiles, converting Fusilli from a header-onlyINTERFACElibrary to a compiledSTATIClibrary.aartifact for downstream consumersfusilli::fusillitarget name unchanged,#include "fusilli/..."paths unchanged)Changes
CMakeLists.txt:
INTERFACE→STATIC, source glob fromsrc/*.cc, visibility keywordsINTERFACE→PUBLIC/PRIVATE, sanitizer/coverage flags for library target,ARCHIVEinstall destinationNew
.ccfiles (8):asm_emitter,runtime,backend,compile_session,compile_command,graph,cache,external_toolsTrimmed headers (8): Implementation bodies removed, declarations retained, templates stay inline
.clang-tidy: Disablellvm-header-guard(computes machine-specific absolute-path guards incompatible with project'sFUSILLI_*style)🤖 Generated with Claude Code