Add support for registry scoped RPSL pk - #1111
Open
jwbensley wants to merge 1 commit into
Open
Conversation
jwbensley
force-pushed
the
registry-scoped-prefix
branch
from
July 27, 2026 15:11
f1f8d8c to
b143e8a
Compare
jwbensley
marked this pull request as ready for review
July 27, 2026 15:23
|
Tick the box to add this pull request to the merge queue (same as
|
Author
|
I added more unit tests, I see 100% tests passing and 100% test coverage. |
jwbensley
force-pushed
the
registry-scoped-prefix
branch
from
July 30, 2026 10:46
ec7aafa to
c74ccb4
Compare
Author
|
Ready @mxsasha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 2nd attempt at adding a registry scope for an AS-SET or ASN.
Last time it was agreed that having a dedicated type was a better way to go, to avoid string matching/parsing. That is what I have done this time, although there is no 100% avoiding string matching/parsing;
asnPrefixesor a registry scoped SET name forasSetPrefixesandrecursiveSetMembers, but the registry scope is optional and defaults toNoneto support backwards compatibility).