Skip to content

Add support for registry scoped RPSL pk - #1111

Open
jwbensley wants to merge 1 commit into
irrdnet:mainfrom
jwbensley:registry-scoped-prefix
Open

Add support for registry scoped RPSL pk#1111
jwbensley wants to merge 1 commit into
irrdnet:mainfrom
jwbensley:registry-scoped-prefix

Conversation

@jwbensley

@jwbensley jwbensley commented Jul 27, 2026

Copy link
Copy Markdown

A 2nd attempt at adding a registry scope for an AS-SET or ASN.

Last time it was agreed that having a dedicated type was a better way to go, to avoid string matching/parsing. That is what I have done this time, although there is no 100% avoiding string matching/parsing;

  • The GrahphQL list type needs to be a list of a single type, so it is now a list of the new type (either a registry scoped ASN type for asnPrefixes or a registry scoped SET name for asSetPrefixes and recursiveSetMembers, but the registry scope is optional and defaults to None to support backwards compatibility).
  • Even if lists of two types were supported, we'd need to string match/parse each entry to work out which type was input by the user, and then we'd end up with two types that have to be handled differently. One type which can optionally be registry scoped is cleaner I think.
  • All docs and tests updated.
  • Full discloser; Copilot is always on in my code editor auto-completing as I write, so some percentage of this is AI generated, but I proof read everything, ensured all tests and docs were updated, and passing, before opening the PR.

@jwbensley
jwbensley force-pushed the registry-scoped-prefix branch from f1f8d8c to b143e8a Compare July 27, 2026 15:11
@jwbensley
jwbensley marked this pull request as ready for review July 27, 2026 15:23
@mergify

mergify Bot commented Jul 27, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@jwbensley

jwbensley commented Jul 30, 2026

Copy link
Copy Markdown
Author

I added more unit tests, I see 100% tests passing and 100% test coverage.
I don't know why the integration tests are failing, it doesn't seems to relate to the files I've changed. I'm also struggling to get the integration tests to run locally.

pytest --cov-report term-missing:skip-covered --cov=irrd -x -vv irrd

...
---------- coverage: platform linux, python 3.12.3-final-0 -----------
Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   11549      0   100%

125 files skipped due to complete coverage.

================================================================================== 816 passed, 43 warnings in 118.31s (0:01:58)

@jwbensley
jwbensley force-pushed the registry-scoped-prefix branch from ec7aafa to c74ccb4 Compare July 30, 2026 10:46
@jwbensley

Copy link
Copy Markdown
Author

Ready @mxsasha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant