Skip to content

Replaces deprecated --headless with --viz none in mimic tests #5378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
njawale42 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Replaces deprecated --headless with --viz none in mimic tests #5378

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79a8084
Replaces deprecated --headless with --viz none in mimic tests
njawale42 Apr 23, 2026
bfa01e9
Bumps isaaclab_mimic to 1.2.5 with --headless deprecation fix entry
njawale42 Apr 23, 2026
6d4efc0
Small formatting discrepancy
njawale42 Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/isaaclab_mimic/config/extension.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]

# Semantic Versioning is used: https://semver.org/
version = "1.2.4"
version = "1.2.5"

# Description
category = "isaaclab"
Expand Down
10 changes: 10 additions & 0 deletions source/isaaclab_mimic/docs/CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
Changelog
---------

1.2.5 (2026-04-23)
~~~~~~~~~~~~~~~~~~~

Changed
^^^^^
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 RST underline too short for section header

In reStructuredText, the underline must be at least as long as the title text. "Changed" is 7 characters, but the underline ^^^^^ is only 5 characters — this will produce a Sphinx/docutils warning (or error depending on config) when the docs are built. All other "Changed" headers in this file use ^^^^^^^.

Suggested change
^^^^^
^^^^^^^


* Replaced the deprecated ``--headless`` CLI flag with ``--viz none`` in the dataset-generation
tests under ``isaaclab_mimic/test/`` to silence the ``AppLauncher`` deprecation warning.


1.2.4 (2026-04-06)
~~~~~~~~~~~~~~~~~~~

Expand Down
6 changes: 4 additions & 2 deletions source/isaaclab_mimic/test/test_generate_dataset_franka_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ def setup_test_environment():
"--output_file",
annotated_output_path,
"--auto",
"--headless",
"--viz",
"none",
]
print(config_command)

Expand Down Expand Up @@ -139,7 +140,8 @@ def _run_generation(workflow_root: str, input_file: str, output_file: str, num_e
str(num_envs),
"--generation_num_trials",
"1",
"--headless",
"--viz",
"none",
]

result = run_script(command, timeout=_SUBPROCESS_TIMEOUT)
Expand Down
3 changes: 2 additions & 1 deletion source/isaaclab_mimic/test/test_generate_dataset_franka_visuomotor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ def _run_generation(workflow_root: str, input_file: str, output_file: str, num_e
"--generation_num_trials",
"1",
"--enable_cameras",
"--headless",
"--viz",
"none",
]

result = run_script(command)
Expand Down
3 changes: 2 additions & 1 deletion source/isaaclab_mimic/test/test_generate_dataset_gr1t2_nutpour.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ def _run_generation(workflow_root: str, input_file: str, output_file: str, num_e
"--generation_num_trials",
"1",
"--enable_cameras",
"--headless",
"--viz",
"none",
]

result = run_script(command)
Expand Down
3 changes: 2 additions & 1 deletion source/isaaclab_mimic/test/test_generate_dataset_gr1t2_pickplace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ def _run_generation(workflow_root: str, input_file: str, output_file: str, num_e
str(num_envs),
"--generation_num_trials",
"1",
"--headless",
"--viz",
"none",
]

result = run_script(command)
Expand Down
3 changes: 2 additions & 1 deletion source/isaaclab_mimic/test/test_generate_dataset_skillgen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ def test_generate_dataset_skillgen(setup_skillgen_test_environment):
"--generation_num_trials",
"1",
"--use_skillgen",
"--headless",
"--viz",
"none",
"--task",
"Isaac-Stack-Cube-Franka-IK-Rel-Skillgen-v0",
]
Expand Down
Loading