Skip to content

Fix usd-core 25.8 / usd-exchange ABI conflict by relaxing version pin #5386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fan-ziqi wants to merge 1 commit into
base: develop
Choose a base branch
from
+1 −1
Open

Fix usd-core 25.8 / usd-exchange ABI conflict by relaxing version pin #5386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/isaaclab/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
]
# Adds OpenUSD dependencies based on architecture for Kit less mode.
INSTALL_REQUIRES += [
f"usd-core==25.8.0 ; ({SUPPORTED_ARCHS})",
f"usd-core>=25.8.0,<26.0.0 ; ({SUPPORTED_ARCHS})",
f"usd-exchange>=2.2 ; ({SUPPORTED_ARCHS_ARM})",
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing upper bound on usd-exchange

usd-exchange>=2.2 has no upper cap. If a future usd-exchange 2.x release ships pxr/ modules built against a different USD ABI, the same class of conflict can recur. The PR description's own recommendation #2 suggests pinning to known-compatible pairs — adding <2.3 (or whichever version is the next known-good boundary) here would make the constraint self-documenting and guard against silent breakage on the next usd-exchange release.

Suggested change
f"usd-exchange>=2.2 ; ({SUPPORTED_ARCHS_ARM})",
f"usd-exchange>=2.2,<2.3 ; ({SUPPORTED_ARCHS_ARM})",

]

Expand Down
Loading