Skip to content

Update deformable showroom image#5392

Merged
kellyguo11 merged 1 commit intoisaac-sim:developfrom
mmichelis:mym/deformable_showroom_update
Apr 25, 2026
Merged

Update deformable showroom image#5392
kellyguo11 merged 1 commit intoisaac-sim:developfrom
mmichelis:mym/deformable_showroom_update

Conversation

@mmichelis
Copy link
Copy Markdown

Description

The previous image on the deformable demo does not include USD assets and surface meshes. This image now corresponds to the updated demo.

Type of change

  • Documentation update

Screenshots

Before After
deformables_before deformables_after

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Apr 24, 2026
Copy link
Copy Markdown

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Isaac Lab Review Bot

Summary

This PR updates a documentation screenshot (deformables.jpg) to reflect the current state of the deformable showroom demo, which now includes USD assets and surface meshes. This is a binary image file replacement with no code changes.

Architecture Impact

Self-contained. This is a static documentation asset with no code dependencies. The image is referenced in documentation pages showing the deformables demo, and updating it has no functional impact on the codebase.

Implementation Verdict

Ship it — This is a straightforward documentation image update with no risk.

Test Coverage

Not applicable for documentation image updates. No tests are needed or expected for static asset changes.

CI Status

No CI checks available yet. For a binary image replacement, the standard CI checks (linting, unit tests) are not meaningfully affected.

Findings

🔵 Improvement: PR checklist accuracy
The PR checklist marks several items as complete that don't apply to this change:

  • "I have added tests that prove my fix is effective" — No tests are needed for an image update
  • "I have updated the changelog and the corresponding version in the extension's config/extension.toml file" — Documentation image updates typically don't require changelog entries

This is a minor observation and doesn't block the PR, but future documentation-only PRs could use a simplified checklist or mark N/A items appropriately.


No blocking issues. This is a clean documentation update that improves the accuracy of the showroom demo screenshot.

@kellyguo11 kellyguo11 merged commit 4af4969 into isaac-sim:develop Apr 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants