Skip to content

Get version tag from GIT when parameter not given #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonihele merged 2 commits into from
Jan 8, 2026
Merged

Get version tag from GIT when parameter not given #693

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5048e80
Get version tag from GIT when parameter not given
tonihele Jan 8, 2026
00f2935
Null expected
tonihele Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions version.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ buildscript {
mavenCentral()
}
dependencies {
classpath 'org.ajoberstar:gradle-git:1.2.0'
classpath 'org.ajoberstar:gradle-git:1.6.0'
}
}

Expand Down Expand Up @@ -140,7 +140,7 @@ task configureVersionInfo {
if (project.hasProperty("tag_name")) {
jmeGitTag = project.getProperty("tag_name")
} else {
jmeGitTag = grgit.tag.list().find { it.commit == head }
jmeGitTag = grgit.tag.list().find { it.commit == head }?.name ?: "no-tag"
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "no-tag" as the default value will cause getReleaseInfo() to print warning messages about an erroneous tag since it doesn't match the expected version format. Consider using an empty string "" or null instead, which getReleaseInfo() explicitly handles at lines 60-63 by returning null without warnings.

Suggested change
jmeGitTag = grgit.tag.list().find { it.commit == head }?.name ?: "no-tag"
jmeGitTag = grgit.tag.list().find { it.commit == head }?.name ?: ""

Copilot uses AI. Check for mistakes.
}

def releaseInfo = getReleaseInfo(jmeGitTag)
Expand Down