Skip to content

fix: honor manual cdp endpoints#869

Open
Astro-Han wants to merge 1 commit intojackwener:mainfrom
Astro-Han:fix/cdp-endpoint-routing
Open

fix: honor manual cdp endpoints#869
Astro-Han wants to merge 1 commit intojackwener:mainfrom
Astro-Han:fix/cdp-endpoint-routing

Conversation

@Astro-Han
Copy link
Copy Markdown
Contributor

Description

Honor OPENCLI_CDP_ENDPOINT across non-Electron browser flows that were still forcing Browser Bridge.

Related issue: #867

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🌐 New site adapter
  • 📝 Documentation
  • ♻️ Refactor
  • 🔧 CI / build / tooling

Checklist

  • I ran the checks relevant to this PR
  • I updated tests or docs if needed
  • I included output or screenshots when useful

Documentation (if adding/modifying an adapter)

  • Added doc page under docs/adapters/ (if new adapter)
  • Updated docs/adapters/index.md table (if new adapter)
  • Updated sidebar in docs/.vitepress/config.mts (if new adapter)
  • Updated README.md / README.zh-CN.md when command discoverability changed
  • Used positional args for the command's primary subject unless a named flag is clearly better
  • Normalized expected adapter failures to CliError subclasses instead of raw Error

Screenshots / Output

npx vitest run src/browser/cdp.test.ts src/runtime.test.ts src/execution-routing.test.ts src/cli-operate.test.ts
PASS: 4 files, 10 tests

npm test
FAIL: existing unrelated repo issue in src/clis/binance/commands.test.ts
Cannot find module '../../pipeline.js'

npx tsc --noEmit
FAIL: same existing unrelated repo issue in src/clis/binance/commands.test.ts
Cannot find module '../../pipeline.js'

@Astro-Han
Copy link
Copy Markdown
Contributor Author

CI is failing on an existing unrelated repo issue, not on the CDP endpoint changes in this PR.

The failing jobs stop at the same error in src/clis/binance/commands.test.ts:

error TS2307: Cannot find module '../../pipeline.js'

That shows up during the repo build and unit test setup, before anything specific to this PR's runtime, execution, operate, or CDP transport changes is exercised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant