Skip to content

fix: fallback to undiciFetch when globalThis.fetch is unavailable #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deep-innovator wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix: fallback to undiciFetch when globalThis.fetch is unavailable #840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/node-network.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ interface ProxyConfig {
let installed = false;
const directDispatcher = new Agent();
const proxyDispatcherCache = new Map<string, Dispatcher>();
const nativeFetch = globalThis.fetch.bind(globalThis);
const nativeFetch = globalThis.fetch
Copy link
Copy Markdown
Contributor

@Astro-Han Astro-Han Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be simpler to make nativeFetch a tiny wrapper instead of choosing once at module load? As written, if fetch is missing during import but gets installed later, the direct path is still pinned to undiciFetch for the rest of the process.

? globalThis.fetch.bind(globalThis)
: (input, init) => undiciFetch(input, init);

function readEnv(env: NodeJS.ProcessEnv, lower: string, upper: string): string | undefined {
const lowerValue = env[lower];
Expand Down