Update logos to include registered trademark#1673
Draft
oliviergoulet5 wants to merge 2 commits intojakartaee:srcfrom
Draft
Update logos to include registered trademark#1673oliviergoulet5 wants to merge 2 commits intojakartaee:srcfrom
oliviergoulet5 wants to merge 2 commits intojakartaee:srcfrom
Conversation
✅ Deploy Preview for jakartaee ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
oliviergoulet5
requested review from
ZacharySabourin,
autumnfound,
chrisguindon and
ericpoirier
Member
|
I am fine with switching to .svg but some webpages (internal and/or external) might be using these logo files that you are deleting. I am thinking it would be safer to update them but replace them with the latest version. |
Member
Author
I was afraid that would be the case... My goal was to clean this directory up with the logo name convention that Mehrnaz uses. I'll create another patch which just updates the images instead of deleting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1672