feat: Codex support#8118
Conversation
…eserve bare string shorthand Co-authored-by: Copilot <copilot@github.com>
…tings - Implemented JanCodeRecommendation component for model selection and download management. - Created SettingsIntegrationPage for better organization of settings UI. - Added Codex integration route and settings management with local storage persistence. - Enhanced SettingsMenu to include Codex option. - Developed useCodexSettings hook for managing Codex model settings. - Updated Claude Code integration to utilize new components and improve UI. - Added tests for useCodexSettings to ensure functionality. Co-authored-by: Copilot <copilot@github.com>
…ma to handle bare string shorthand Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: thewulf7 <1582808+thewulf7@users.noreply.github.com>
Review: feat: Codex supportSummaryThis is a large PR (17 files, ~2200 additions, ~500 deletions) that adds OpenAI Codex CLI integration to Jan. The changes span three major areas:
Strengths
Issues and Concerns
Architecture NotesThe approach of normalizing Codex /responses API requests into something llama.cpp can handle at the proxy level is sound. The alternative would be to implement /responses support in the downstream server, which is much more work. The proxy transformation layer is a pragmatic choice. Merge ReadinessThis is a substantial feature PR with good test coverage for the critical proxy normalization logic. The issues identified are mostly about code quality and edge cases rather than correctness. The hardcoded context window values and the duplicated schema normalization are the most important items to address before merge. Recommendation: improve needed |
…dling functions
Describe Your Changes