fix: jan parser is broken with nested tool call tag in arguments#2
Open
louis-jan wants to merge 1 commit into
Open
fix: jan parser is broken with nested tool call tag in arguments#2louis-jan wants to merge 1 commit into
louis-jan wants to merge 1 commit into
Conversation
louis-jan
force-pushed
the
fix/jan-parser-nested-tool-call-tag
branch
from
0934d3a to
36cc954
Compare
nguyenhoangthuan99
pushed a commit
that referenced
this pull request
Feb 2, 2026
…3058) Signed-off-by: ramos <49182011+nemoramo@users.noreply.github.com> Signed-off-by: mayufeng <mayufeng@example.com> Co-authored-by: mayufeng <mayufeng@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix nested tool_call tag in tool call arguments
Purpose
This PR fixed a case where nested <tool_call> in argument values will break the parser hence it create broken output.
Also added unit tests for other cases
Tool call:
{"arguments":{"q": "Search about "}}Content:
Parser stop before seeing <tool_call> tag
It breaks so the rest of the tool call goes to
contentpart