Skip to content

Update Ruff to >=0.13 and simplify configs #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Avasam wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −14
Open

Update Ruff to >=0.13 and simplify configs #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ doc = [
check = [
"pytest-checkdocs >= 2.14",
"pytest-ruff >= 0.2.1; sys_platform != 'cygwin'",
# Deprecated rules must now be selected by exact rule code
"ruff >= 0.13; sys_platform != 'cygwin'",
Comment on lines +54 to +55
Copy link
Copy Markdown
Contributor Author

@Avasam Avasam Oct 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, this can be set directly in ruff.toml with required-version. The UX is not great if updating from before version 0.14.11 as it used to fails at runtime w/o telling you to re-sync your dependencies (astral-sh/ruff#19922)

]

cover = [
Expand Down
18 changes: 4 additions & 14 deletions ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,35 +11,25 @@ extend-select = [
"FA", # flake8-future-annotations
"F404", # late-future-import
"PYI", # flake8-pyi
"UP006", # non-pep585-annotation
"UP007", # non-pep604-annotation
"UP010", # unnecessary-future-import
"UP035", # deprecated-import
"UP037", # quoted-annotation
"UP043", # unnecessary-default-type-args

# Code modernization (strings, annotations, conditions, ...)
"UP", # pyupgrade
Copy link
Copy Markdown
Contributor Author

@Avasam Avasam Oct 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively:

	"C901", # complex-structure
	"I", # isort
	"PERF401", # manual-list-comprehension
+	"UP", # pyupgrade (Code modernization for strings, annotations, conditions, ...)
	
	# Ensure modern type annotation syntax and best practices
	# Not including those covered by type-checkers or exclusive to Python 3.11+
	"FA", # flake8-future-annotations
	"F404", # late-future-import
	"PYI", # flake8-pyi
-	
-	# Code modernization (strings, annotations, conditions, ...)
-	"UP", # pyupgrade

Copy link
Copy Markdown
Owner

@jaraco jaraco Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a slight preference for this alternative, as it's more compact.


# local
]
ignore = [
# upstream
"UP015", # redundant-open-modes, explicit is preferred

# Typeshed rejects complex or non-literal defaults for maintenance and testing reasons,
# irrelevant to this project.
"PYI011", # typed-argument-default-in-stub
# https://docs.astral.sh/ruff/formatter/#conflicting-lint-rules
"W191",
"E111",
"E114",
"E117",
"D206",
"D300",
"Q000",
"Q001",
"Q002",
"Q003",
"COM812",
"COM819",

Copy link
Copy Markdown
Owner

@jaraco jaraco Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep this space for separation.

# local
]

Expand Down
Loading