Use the public on method when listening#4131
Merged
megawac merged 4 commits intojashkenas:masterfrom Apr 9, 2017
jbboehr:private-listening-public-on
Merged
Use the public on method when listening#4131megawac merged 4 commits intojashkenas:masterfrom jbboehr:private-listening-public-on
on method when listening#4131megawac merged 4 commits intojashkenas:masterfrom
jbboehr:private-listening-public-on
Conversation
This uses a private `listening` var to share state between a Backbone "listener" and "listenee", instead of using a private `internalOn()` to share state. This allows `#listenTo` to use the public `#on` method and keeps interop between Backbone and any other event library.
A more descriptive name for what the property signifies.
Collaborator
|
/cc @jridgewell |
Contributor
Author
|
I'm gluing together a sockjs client and a cross-tab communication library, but without this patch, |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've merged master into #3615. Any reason it was never merged before?