Skip to content

Miscellaneous corrections#131

Open
jatkinson1000 wants to merge 1 commit into
mainfrom
misc_patches
Open

Miscellaneous corrections#131
jatkinson1000 wants to merge 1 commit into
mainfrom
misc_patches

Conversation

@jatkinson1000

Copy link
Copy Markdown
Owner

A PR to collect various corrections spotted whilst going through the code.

  • Update outdated module docstrings in handicap_functions to reflect refactored code.

@jatkinson1000

Copy link
Copy Markdown
Owner Author

Consider updating internal round names for 6_zone to instead of small.
Consider updating name of WA 70m to WA 720 (70m) etc.

@codecov

codecov Bot commented Apr 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.94%. Comparing base (77e8cfb) to head (d9dd430).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files          31       31           
  Lines        2043     2043           
=======================================
  Hits         2001     2001           
  Misses         42       42           
Files with missing lines Coverage Δ
archeryutils/handicaps/handicap_functions.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mjtamlyn

Copy link
Copy Markdown
Contributor

👍

@jatkinson1000

Copy link
Copy Markdown
Owner Author

@mjtamlyn I'm tempted to separate name changes and updates here until we settle on a definitive new system...

I'd consider trying to do some backwards compatibility mapping for legacy names.

@mjtamlyn

Copy link
Copy Markdown
Contributor

Yeah once all the names are decided we should just do it all in one go. We can also get rid of the duplication on archery calculator at the same time.

@jatkinson1000 jatkinson1000 force-pushed the main branch 4 times, most recently from 61111ce to 81bcce5 Compare May 28, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants