Class fraction#91
Open
jatkinson1000 wants to merge 13 commits into
Open
Conversation
jatkinson1000
commented
Jul 15, 2024
jatkinson1000
left a comment
Owner
Author
There was a problem hiding this comment.
Should probably use type of classification in the function name for consistency elsewhere. No other schemes can use this at present, but field will need it in #46
Owner
Author
|
Need to add a check for when handicap and score can overlap slightly either way at boundaries after being rounded to integers. Roughly:
|
4625170 to
29fce01
Compare
…tdoor with boundary scores.
… score in outdoor and ignore related line in indoor that will not be triggered.
jatkinson1000
commented
Jul 15, 2024
jatkinson1000
left a comment
Owner
Author
There was a problem hiding this comment.
Think this is now OK to go.
Consider bumping to 1.1.0 and adding a release, or instead wait until larger changes such as #46 come in.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 97.64% 97.95% +0.30%
==========================================
Files 28 28
Lines 1613 1710 +97
==========================================
+ Hits 1575 1675 +100
+ Misses 38 35 -3
🚀 New features to boost your workflow:
|
61111ce to
81bcce5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the functionality of giving the 'fraction through a classification' a score is based on the handicap.
As requested by users.