Fix panMode locking sticker select and transform - #42
Merged
Conversation
- Lock select/drag/resize/rotate/pinch while panMode or Space is active - Bump react-canvas-designer to 1.3.1 and update pins/docs - Add always-apply rule: agents must not publish packages locally (CI on master) Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While
panMode(or Space) is active, stickers could still be selected, dragged, and rotated. This locks sticker interaction for the full pan session and bumps@jeffgo10/react-canvas-designerto 1.3.1. Also adds an always-apply Cursor rule so agents do not publish packages locally (CI publishes on merge tomaster).Changes
Packages (
@jeffgo10/*)@jeffgo10/react-canvas-designer1.3.1: while pan is active, sticker groups uselistening={false}, Transformer handles are cleared/disabled, and pinch /[]rotate are blockedDocs / Cursor rules / agent tooling
phase-1.md, engineering notes, READMEls-foundry-no-manual-publish.mdc; core +/extract-to-foundrypoint agents at CI publish onlyCommits
47c1d72Test plan
pnpm test --filter=@jeffgo10/react-canvas-designerpnpm run build:packagespnpm run dev --filter=@ls-foundry/docs→/stickpak: enable Pan mode — cannot select/move/rotate stickers; disable pan — editing works againNotes / follow-ups
/create-github-pr cleanupMade with Cursor