Add panorama-viewer gyro tilt-to-look and marker drag (0.2.0) - #47
Merged
Conversation
- Expose orientationControl / startOrientation for mobile view mode - Add edit-mode hotspot drag via onMarkerMove without remounting - Document iOS permission constraints; enable gyro in /panorama demo Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
@jeffgo10/panorama-viewerto 0.2.0 for RoamVantage / Vantage: mobile tilt-to-look (Pannellum device orientation) and edit-mode marker drag. Existing props stay stable; gyro is view-mode only so edit click-to-place and drag-vs-click keep working.Changes
Packages (
@jeffgo10/panorama-viewer)orientationControl,orientationOnByDefault,onOrientationChangestartOrientation,stopOrientation,isOrientationAvailable,isOrientationActivedeviceOrientationPermissionRequired,isOrientationControlEnabledonMarkerMove(structural vs position keys; no remount on yaw/pitch)Docs app (
apps/docs)orientationControlin VIEW on/panorama; surface gyro on/off in last-event lineDocs / Cursor rules
docs/panorama-viewer/*and pin table inls-foundry-core.mdcto 0.2.0Commits
84a5c34Test plan
pnpm test --filter=@jeffgo10/panorama-viewerpnpm run build --filter=@jeffgo10/panorama-viewerpnpm run dev --filter=@ls-foundry/docs→/panorama— VIEW shows orientation control; EDIT drag repositions hotspotsorientationControl(optionalorientationOnByDefault)Notes / follow-ups
@jeffgo10/panorama-viewer@0.2.0on merge tomaster(do not publish locally)./update-ls-foundry-packagesin roamvantage, then wireorientationControlonPublicTourViewer/ demo; add host “Enable motion” button for iOS if needed.Made with Cursor