ignore pac4j Dependabot bumps pending upstream fix - #781
Merged
jtnord merged 2 commits intoAug 4, 2026
Conversation
nevingeorgesunny
changed the title
nevingeorgesunny
marked this pull request as ready for review
July 31, 2026 11:49
jtnord
approved these changes
Aug 4, 2026
Member
|
For this kind of situation I recommend creating a draft PR reverting the exclusion, to serve as a reminder to future maintainers to revisit. Otherwise the pac4j problem might get fixed, nobody here gets the notification, nobody remembers to revert the exclusion, and we do not get updates for years until someone is pestered by a CVE notification and wonders why there are no Dependabot PRs picking up the fix. |
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Dependabot ignore rule for all
org.pac4j:*dependencies to preventautomated bumps to pac4j 6.5.x and above.
compliments #767 (review)
Why
pac4j commit a0fbdd610b ("rework build", April 2026) moved 12 test utility
classes from
src/test/javaintosrc/main/java, causing them to ship insidethe production
saml-plugin is currently on pac4j 6.4.1 which predates this change and is
not affected. The ignore rule prevents Dependabot from bumping to 6.5.0+
until the upstream fix is in place.