feat: Get Content-Type from CLI argument#13
Open
entrity wants to merge 1 commit into
Open
Conversation
🎯 Motivation Some MDM servers may require a particular Content-Type header value for posted data. We aim to let users specify a value. 🦋 What's changed - A command-line argument `--content-type` is added. - The default Content-Type value is changed from `application/octet-stream` to `application/x-pki-message`. 🔗 References Closes jessepeterson#12
Author
|
I am not familiar with golang projects, so any requests for changes are welcome. |
jessepeterson
requested changes
Dec 16, 2025
| "github.com/smallstep/scep" | ||
| ) | ||
|
|
||
| var RequestContentType = "application/x-pki-message" |
Owner
There was a problem hiding this comment.
Generally we want to stay away from global variables. This can just be a property on the client struct (since that's where it's used) and initialized as an option in the client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Motivation
Some MDM servers may require a particular Content-Type header value for posted data. We aim to let users specify a value.
🦋 What's changed
A command-line argument
--content-typeis added.The default Content-Type value is changed from
application/octet-streamtoapplication/x-pki-message.🔗 References
Closes #12