Skip to content

[artifactory-ha] Transition from awssdkv1 to awssdkv2 #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
charmdcmc wants to merge 1 commit into from
Closed

[artifactory-ha] Transition from awssdkv1 to awssdkv2 #2274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions stable/artifactory-ha/files/binarystore.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,9 @@

{{- with .Values.artifactory.persistence.awsS3V3 }}
<provider id="s3-storage-v3" type="s3-storage-v3">
{{- if .awssdkv2}}
<awsSdkV2>true</awsSdkV2>
{{- end }}
<testConnection>{{ .testConnection }}</testConnection>
{{- if .identity }}
<identity>{{ .identity }}</identity>
Expand Down Expand Up @@ -457,10 +460,10 @@
{{- end }}
{{- end }}
<endpoint>{{ .Values.artifactory.persistence.azureBlob.endpoint }}</endpoint>
<container>{{ .Values.artifactory.persistence.azureBlob.containerName }}</container>
<container>{{ .Values.artifactory.persistence.azureBlob.containerName }}</container>
<multiPartLimit>{{ .Values.artifactory.persistence.azureBlob.multiPartLimit | int64 }}</multiPartLimit>
<multipartElementSize>{{ .Values.artifactory.persistence.azureBlob.multipartElementSize | int64 }}</multipartElementSize>
<testConnection>{{ .Values.artifactory.persistence.azureBlob.testConnection }}</testConnection>
</provider>
</provider>
</config>
{{- end }}
1 change: 1 addition & 0 deletions stable/artifactory-ha/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,7 @@ artifactory:
# signedUrlExpirySeconds: 30
## For artifactory.persistence.type aws-s3-v3, s3-storage-v3-direct, s3-storage-v3-archive
awsS3V3:
awssdkv2: true
testConnection: false
identity:
credential:
Expand Down
7 changes: 5 additions & 2 deletions stable/artifactory/files/binarystore.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,9 @@

{{- with .Values.artifactory.persistence.awsS3V3 }}
<provider id="s3-storage-v3" type="s3-storage-v3">
{{- if .awssdkv2}}
<awsSdkV2>true</awsSdkV2>
{{- end }}
<testConnection>{{ .testConnection }}</testConnection>
{{- if .identity }}
<identity>{{ .identity }}</identity>
Expand Down Expand Up @@ -444,10 +447,10 @@
{{- end }}
{{- end }}
<endpoint>{{ .Values.artifactory.persistence.azureBlob.endpoint }}</endpoint>
<container>{{ .Values.artifactory.persistence.azureBlob.containerName }}</container>
<container>{{ .Values.artifactory.persistence.azureBlob.containerName }}</container>
<multiPartLimit>{{ .Values.artifactory.persistence.azureBlob.multiPartLimit | int64 }}</multiPartLimit>
<multipartElementSize>{{ .Values.artifactory.persistence.azureBlob.multipartElementSize | int64 }}</multipartElementSize>
<testConnection>{{ .Values.artifactory.persistence.azureBlob.testConnection }}</testConnection>
</provider>
</provider>
</config>
{{- end }}
1 change: 1 addition & 0 deletions stable/artifactory/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,6 +891,7 @@ artifactory:
# signedUrlExpirySeconds: 30
## For artifactory.persistence.type aws-s3-v3, s3-storage-v3-direct, cluster-s3-storage-v3, s3-storage-v3-archive
awsS3V3:
awssdkv2: true
testConnection: false
identity:
credential:
Expand Down
Loading