Skip to content

RTECO-1074 - Remove redundant functions in agent namespace-2#3567

Merged
udaykb2 merged 6 commits into
masterfrom
RTECO-1074-Remove-agent-redundent-functions-2
Jun 23, 2026
Merged

RTECO-1074 - Remove redundant functions in agent namespace-2#3567
udaykb2 merged 6 commits into
masterfrom
RTECO-1074-Remove-agent-redundent-functions-2

Conversation

@udaykb2

@udaykb2 udaykb2 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Summary

Add dependency reference to jfrog-cli-artifactory PR: jfrog/jfrog-cli-artifactory#498

This dependency reference bring the following changes:

  • Removed duplicate ValidateInstallFlags from skills and plugins.
  • Moved shared validation into agent/common/install_flags.go, split into small helpers (path mode, harness mode, flag parsing).
  • Skills/plugins commands now call agentcommon.ValidateInstallFlags directly with their own agent registry (Agents, config key, RegistryHelp).
  • Tests consolidated in agent/common; wrapper functions and wrapper smoke tests removed.
  • Behavior unchanged; all tests pass.

@udaykb2 udaykb2 added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Jun 23, 2026
@udaykb2 udaykb2 force-pushed the RTECO-1074-Remove-agent-redundent-functions-2 branch from 1f414ca to 66b0d1f Compare June 23, 2026 05:22
@udaykb2 udaykb2 requested review from a team, agrasth, bhanurp, fluxxBot, itsmeleela and reshmifrog and removed request for a team June 23, 2026 05:30
@udaykb2 udaykb2 force-pushed the RTECO-1074-Remove-agent-redundent-functions-2 branch from 66b0d1f to 93a0fdc Compare June 23, 2026 06:09

@naveenku-jfrog naveenku-jfrog left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticket Alignment

  • Implements ticket requirement: Yes — the PR fulfils RTECO-1074 by bumping jfrog-cli-artifactory to the commit that contains the companion PR's refactoring (removing duplicate ValidateInstallFlags, consolidating shared logic into agent/common/install_flags.go).
  • Missing from ticket: The actual code removals/consolidation live in jfrog-cli-artifactory PR #498, which is not reviewable in this diff. The ticket is only fully satisfied once that companion PR is merged and a stable release is cut.
  • Out of scope: Nothing in the diff is out of scope for the ticket.

Findings

# Severity Category Location Issue Impact Suggested Fix
1 Major 🟠 Maintainability / API Contract go.mod:253 An active (uncommented) replace directive is added outside the established replace (...) block, pointing to an unreleased pseudo-version (v0.8.1-0.20260623051013-416d69d80d8e). Every other dev-time replacement in this file is commented out (//replace ...). Merging to master pins all CLI builds to commit 416d69d80d8e. If that commit is rebased, amended, or the companion branch changes, builds silently break or diverge from the published module registry. The unconventional placement (outside the block, active not commented) also makes it easy to miss during cleanup before release. Wait for jfrog-cli-artifactory PR #498 to be merged and a release tag cut; then remove this replace and update go.mod/go.sum to the released version. If this must merge before the companion is released, at minimum add a comment (e.g. // TODO: remove once jfrog-cli-artifactory vX.Y.Z is released — jfrog-cli-artifactory#498) and open a tracking task so it is cleaned up before the release cut.
2 Minor 🔵 Styling go.mod:253 The new replace is appended at the end of the file as a standalone top-level directive rather than inside the existing replace ( ... ) block at lines 5-12 where all other active replacements live. Two separate locations now define module replacements; a reader scanning the replace block at the top will miss this entry. Move it inside the replace ( ... ) block (with a comment explaining the temporary pin), or follow the established convention of commenting it out until it is ready to be active.

Comment thread go.mod Outdated
@udaykb2 udaykb2 force-pushed the RTECO-1074-Remove-agent-redundent-functions-2 branch from 93a0fdc to 448fadd Compare June 23, 2026 06:13
@udaykb2 udaykb2 changed the title RTECO-1074 - Remove redundendent functions in agent namespace-2 RTECO-1074 - Remove redundant functions in agent namespace-2 Jun 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@udaykb2 udaykb2 merged commit c276c02 into master Jun 23, 2026
97 checks passed
@udaykb2 udaykb2 deleted the RTECO-1074-Remove-agent-redundent-functions-2 branch June 23, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes safe to test Approve running integration tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants