RTECO-1074 - Remove redundant functions in agent namespace-2#3567
Merged
Conversation
1f414ca to
66b0d1f
Compare
66b0d1f to
93a0fdc
Compare
naveenku-jfrog
requested changes
Jun 23, 2026
naveenku-jfrog
left a comment
Collaborator
There was a problem hiding this comment.
Ticket Alignment
- Implements ticket requirement: Yes — the PR fulfils RTECO-1074 by bumping
jfrog-cli-artifactoryto the commit that contains the companion PR's refactoring (removing duplicateValidateInstallFlags, consolidating shared logic intoagent/common/install_flags.go). - Missing from ticket: The actual code removals/consolidation live in
jfrog-cli-artifactoryPR #498, which is not reviewable in this diff. The ticket is only fully satisfied once that companion PR is merged and a stable release is cut. - Out of scope: Nothing in the diff is out of scope for the ticket.
Findings
| # | Severity | Category | Location | Issue | Impact | Suggested Fix |
|---|---|---|---|---|---|---|
| 1 | Major 🟠 | Maintainability / API Contract | go.mod:253 |
An active (uncommented) replace directive is added outside the established replace (...) block, pointing to an unreleased pseudo-version (v0.8.1-0.20260623051013-416d69d80d8e). Every other dev-time replacement in this file is commented out (//replace ...). |
Merging to master pins all CLI builds to commit 416d69d80d8e. If that commit is rebased, amended, or the companion branch changes, builds silently break or diverge from the published module registry. The unconventional placement (outside the block, active not commented) also makes it easy to miss during cleanup before release. |
Wait for jfrog-cli-artifactory PR #498 to be merged and a release tag cut; then remove this replace and update go.mod/go.sum to the released version. If this must merge before the companion is released, at minimum add a comment (e.g. // TODO: remove once jfrog-cli-artifactory vX.Y.Z is released — jfrog-cli-artifactory#498) and open a tracking task so it is cleaned up before the release cut. |
| 2 | Minor 🔵 | Styling | go.mod:253 |
The new replace is appended at the end of the file as a standalone top-level directive rather than inside the existing replace ( ... ) block at lines 5-12 where all other active replacements live. |
Two separate locations now define module replacements; a reader scanning the replace block at the top will miss this entry. |
Move it inside the replace ( ... ) block (with a comment explaining the temporary pin), or follow the established convention of commenting it out until it is ready to be active. |
93a0fdc to
448fadd
Compare
…://github.com/jfrog/jfrog-cli into RTECO-1074-Remove-agent-redundent-functions-2
naveenku-jfrog
approved these changes
Jun 23, 2026
reshmifrog
approved these changes
Jun 23, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

masterbranch.go vet ./....go fmt ./....Summary
Add dependency reference to jfrog-cli-artifactory PR: jfrog/jfrog-cli-artifactory#498
This dependency reference bring the following changes: