Skip to content

https://github.com/jfrog/jfrog-cli/pull/3441#top --> to loader.go #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Cesar-DC wants to merge 1 commit into from
Closed

https://github.com/jfrog/jfrog-cli/pull/3441#top --> to loader.go #1346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion auth/cert/loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,11 @@ func LoadCertificate(clientCertPath, clientCertKeyPath string) (certificate tls.

func GetTransportWithLoadedCert(certificatesDirPath string, insecureTls bool, transport *http.Transport) (*http.Transport, error) {
// Remove once SystemCertPool supports windows

@RemiBou RemiBou May 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove the comment, can you implement some tests ?

caCertPool, err := loadSystemRoots()
caCertPool, err := x509.SystemCertPool()
if caCertPool == nil {
caCertPool = x509.NewCertPool()
}

err = errorutils.CheckError(err)
if err != nil {
return nil, err
Expand Down
Loading