Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a Leaflet map is initialised inside a hidden container (e.g. a jQuery UI tab, Bootstrap tab, or modal), map.getSize() returns {x:0, y:0}. This causes _tickRange() to compute tick = 0 or NaN, which in turn makes _lines() return an unbounded or degenerate line array — resulting in no grid being rendered, and in some cases a hang or excessive paint time.
Fix
Add an early return in _lines() before the loop:
if (!tick || !isFinite(tick)) { return []; }This is a no-op for normal usage. It only fires when ticks is 0 or the bounds produce a degenerate range, making the function safe to call regardless of container visibility.
Reproducer
Initialise an L.Grid layer on a map inside a hidden jQuery UI tab. Open the tab (triggering invalidateSize()). Without this fix, the grid does not render. With it, the grid renders correctly once the container is visible.