Refactor/substrate context - #254
Conversation
|
@anton-karlovskiy are you still working on this? Seems at a glance to be an improvement (but I have not tested it at all) |
|
@nukemandan |
|
sure @anton-karlovskiy - can you update the PR comment to include what this PR does? And the README if needed at all for future users? |
|
@nukemandan |
nuke-web3
left a comment
nuke-web3
left a comment
There was a problem hiding this comment.
LGTM and it runs with a dev node with a trivial check of functionality to submit extrinsics.
| Error: 'ERROR' | ||
| }) | ||
|
|
||
| // TODO: use an enum with TypeScript |
There was a problem hiding this comment.
Planning to implement this here or what? ;) Other TODOs exist in here as well.
|
|
||
| dispatch({ type: ActionType.ConnectInit }) | ||
|
|
||
| console.log(`Connected socket: ${socket}`) |
There was a problem hiding this comment.
shouldn't this be Connecting to socket since the socket connection hasn't actually been connected yet and the connection attempt may fail?
|
@nukemandan @ltfschoen |
3 participants
No description provided.