Fix -fanalyzer errors so frogfs builds with CONFIG_COMPILER_STATIC_ANALYZER=y - #78
Open
hyrsky wants to merge 3 commits into
Open
Fix -fanalyzer errors so frogfs builds with CONFIG_COMPILER_STATIC_ANALYZER=y#78hyrsky wants to merge 3 commits into
hyrsky wants to merge 3 commits into
Conversation
frogfs_get_path() returns NULL when its calloc() fails, but frogfs_get_entry() passed the result directly to strcmp() without checking. gcc 15's -fanalyzer flags this as -Wanalyzer-null-argument.
frogfs_vfs_opendir() did not check the malloc result for dh, and also returned without freeing dh when frogfs_get_entry() failed.
open_miniz() returned -1 without freeing priv when the gzip compression method byte was not 8 (deflate).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I wanted to enable CONFIG_COMPILER_STATIC_ANALYZER=y on my project, but frogfs trips three
-fanalyzererrors, so the build fails. This PR fixes all three issues.Fixes #77.