Set context before calculating default namespace #110
Open
andreacab wants to merge 1 commit intojohanhaleby:masterfrom
Open
Set context before calculating default namespace #110andreacab wants to merge 1 commit intojohanhaleby:masterfrom
andreacab wants to merge 1 commit intojohanhaleby:masterfrom
Conversation
…pends on the former
Owner
|
Thanks for the PR! However I find it a bit hacky to set the context like this. I think it should be possible to pass it as an argument to |
Author
|
Hey @johanhaleby totally fair, wasn't happy with my solution either but couldn't come up with a cleaner way. I'll be in standby if you need me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With that change and a following kube config
all calls to kubetail below will work and yield the same result