feat!: switch from ggplot2 to base r graphics#37
Merged
Conversation
Closes #33. The breaking change is that plots look different and that we return NULL invisibly now rather than a ggplot2 object. There are no longer any facetted plots. Instead users need to call `par()` with settings for `mfrow` and/or `mfrow`, or similar, for panelled layouts when `plot.trainedSLOPE` is invoked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33. The breaking change is that plots look different and that we
return NULL invisibly now rather than a ggplot2 object. There are no
longer any facetted plots. Instead users need to call
par()withsettings for
mfrowand/ormfrow, or similar, for panelled layoutswhen
plot.trainedSLOPEis invoked.