Support for hotpatch of static fields#1354
Open
Thrameos wants to merge 7 commits intojpype-project:masterfrom
Open
Support for hotpatch of static fields#1354Thrameos wants to merge 7 commits intojpype-project:masterfrom
Thrameos wants to merge 7 commits intojpype-project:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1354 +/- ##
==========================================
- Coverage 86.30% 86.26% -0.05%
==========================================
Files 113 113
Lines 10532 10551 +19
Branches 4041 4055 +14
==========================================
+ Hits 9090 9102 +12
- Misses 840 847 +7
Partials 602 602
🚀 New features to boost your workflow:
|
Contributor
Author
|
I will need to refresh this one. Unfortunately it exposed a bug that it is impossible to access members that start with underscore from java because we unconditionally gave that space to Python. I also found it very difficult to perform renaming tasks. This PR will fix both those issues. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| PyObject *value = nullptr; | ||
| if (!PyArg_ParseTuple(args, "OO", &name, &value)) | ||
| return nullptr; | ||
| // PyErr_WarnEx(PyExc_DeprecationWarning, "_customize() is deprecated, use "setattr(cls,'.'+name,value)" syntax instead", 1); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a specific edge case. It is an edge case where you want to be able to get to an aliased copy of a member. To make it nicer deal with the descriptors I have added a "." leader which prevent descriptors from being dereference.
Fixes #1328