-
-
Notifications
You must be signed in to change notification settings - Fork 33
Support async sequence types #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d4f56d0
Recognize async_sequence
MattiasBuelens 1fc2e09
Implement conversion for async_sequence
MattiasBuelens c6c791c
Add createAsyncFromSyncIterator
MattiasBuelens a3559ad
Return original object when converting back to JS value
MattiasBuelens c280bbd
Add convertAsyncSequence utility
MattiasBuelens 0c57a06
Fix return method
MattiasBuelens e73e761
Fix next method signature
MattiasBuelens e20ca3f
Add test for code generation
MattiasBuelens 8647a98
Extract isSequenceLike helper
MattiasBuelens 455c6ab
Don't check type of `next` method
MattiasBuelens 1194f23
Use `getMethod` when checking for sequence-like in union
MattiasBuelens cac5310
Improve errors from getMethod
MattiasBuelens 92ddb05
Add properties for async sequence values
MattiasBuelens 8c9d147
Test convertAsyncSequence
MattiasBuelens 7ebf4a1
Test iterables with bad iterator methods
MattiasBuelens 3607ee5
Test wrapperForImpl for async sequence
MattiasBuelens 822c953
Use `expect().resolves`
MattiasBuelens e96e80f
Move comments around
MattiasBuelens 0333001
Move isObject check to convertAsyncSequence
MattiasBuelens c105522
Test with a string
MattiasBuelens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.